ZsoltMolnarrr / BetterCombat

⚔️ Easy, spectacular and fun melee combat system from Minecraft Dungeons.
https://www.curseforge.com/minecraft/mc-mods/better-combat-by-daedelus
Other
120 stars 49 forks source link

Gigantic Lag while using two-handed weapons or seeing someone using. (BendyLib) #258

Open Zaatch opened 1 year ago

Zaatch commented 1 year ago

Minecraft version - 1.19.2 Mod loader - Fabric 0.14.19 Mod version - v1.7.1 I am using the latest version available - YES

Describe the bug Everytime i see someone playing with two-handed weapons... My game just have an enormous lag. I installed first person model mod and i can see the lag too if i use this perspective... Every weapon of every mod that have two-handed weapons... sad :(

To Reproduce Steps to reproduce the behavior:

  1. Grab any weapon that uses two-handed animations (while using first person model mod /edit: happens without this mod too)
  2. Any friend that are using two-handed weapons that you are looking at, you will have this issue (lag).

Expected behavior Not lag :D

Screenshots or video recordings First Person Model image image

Seeing myself on third-person (Or any player) image image

Additional context I tested and i see this issue with: Simplyswords, Minecraft Dungeons Weapons and Marium's Soulslike Weaponry BTW i am using the latest version of every mod.

ZsoltMolnarrr commented 1 year ago

Please provide actionable data on the subject. Specifically the fewest possible mods that can reproduce this problem.

ZsoltMolnarrr commented 1 year ago

Are you using OptiFabric?

Zaatch commented 1 year ago

Are you using OptiFabric?

Nope, but i am using Sodium, Sodium Extra, indium, MemoryLeakFix, Entity Culling, Starlight, Reese's Sodium Options, Lithium, Ferrite Core mods.

List of all mods that i am using below:

Advancement Plaques Ambient Sounds Animal Feeding Through Apple Skin Auditory Auto HUD Auto Switch Auto Third Person Backpacked Backslot Beacon Overhaul Bed Benefits Better Beacon Placement Better Combat Better Mount Hud Better Ping Display Better Than Mending Better ThirdPerson Better Village Bountiful (Fabric) Bow Infinity Fix By Design Carry On Cave Dust Charm of Undying Chat Heads Cherished Worlds Clean Cut Clear Despawn Clumps Companion bats Controlling Cooperative Advancements Cosmetic Armor Craftable Horse Armour & Saddle Dark Loading Screen Dark Paintings Dark Waters Dash's Hardcore Overlay Deepslate Cutting Detail Armor Bar Double Doors Durability101 Dusk Mod Easy Magic Eating Animation Eldritch Mobs Elytra Slot Emote Craft Enchantment Descriptions Ender Dragon Fight Remastered Enhanced Attack Indicator Enhanced Celestials Entity Culling Entity Model Features Equipment Compare Expanded Delight Expert Armor [Fabric/Quilt] Extra Sounds Fabric Chunk Pregenerator Fabric Seasons Falling Leaves Falling Tree Farmer's Delight Farsighted Mobs Fast Portals FastQuit Ferrite Core Fish on the Line Flat Bedrock Food Effect Tooltips Fresh Animations Friendly Fire Friends & Foes Furnish Gliders Go Fish Gotta Go Fast Grindstone Sharper Tools Guard Villagers Hardcore Revival Here be no Dragons! Highlighter Horse Buff Horse Expert Hover Pets Husk Spawn Immediately Fast Immersive Paintings Indium Inv Move Inv View Iris Iron Chests It Takes a Pillage JobsAddon Jump Over Fences Kaffee's Dual Ride Keebsz's Battle Towers Keep my soil Tilled Labelling Containers LambDynamicLights LazyDFU Leathered Boots Legendary Tooltips Let Sleeping Dogs Lie LevelZ Lithium Living Things Lootr Make Bubbles Pop Marium's Soulslike Weaponry MC Dungeons: Armors MC Dungeons: Artifacts MC Dungeons: Weapons Medieval Music MemoryLeakFix Merchant Markers Mob Sunscreen Mod Menu Model Gap Fix More Mob Variants Mouse Wheelie Name Colours No Hostiles Around Campfire No Lan Cheating No More Underwater Dismount No Shield Delay Not Enough Animations Numismatic Overhaul Nyf's Spiders On Soul Fire OST Overhaul Persistent Gamemode Switcher Physics (PRO) Pick Up Notifier Ping Wheel Player Pressure Plates Presence Footsteps Progressive Bosses Public Gui Announcement Realistic Bees Reese's Sodium Options Repurposed Structures Restart Server Right Click Harvest Rotten Flesh to Leather Roughly Enough Items Screenshot to Clipboard Screenshot Viewer Seasons Delight Server Sleep Simple RPC Simple Voice Chat Simply Swords Skeleton Horse Spawn Skinpls Smooth Boot Smooth Swapping Snow Under Trees Snowballs Freeze Mobs Sodium Sodium Extra Spiders Produce Webs Spyglass Improvements Stack Refill Starlight Starter Kit Stonecutter Damage Stray Spawn Structory Superflat World No Slimes The Graveyard The Twilight Forest TimeOut Out Tissou's Zombie Pack Towns and Towers Trash Slot Traveler's Backpack Traveler's Titles Trinkets True Darkness Universal Bone Meal Vein Mining Visual Workbench Visuality Voice Chat Interaction Void Totem Warrior Rage Waystones What's That Slot? When Dungeons Arise Whisperwoods Why stacks of 16? Xaero's Minimap YDM's MobHealthBar You Died You're in Grave Danger Yung's Better Desert Temples Yung's Better Dungeons YUNG's Better Strongholds Yung's Better Witch Huts Yung's Extras Zombie Horse Spawn

ZsoltMolnarrr commented 1 year ago

I am unable to look through which of these hundreds of mods is causing the issue. Please help pinpointing which one is causing the problem, otherwise the issue is non actionable and closed. (Just for reference: not all modpacks experience this issue)

Zaatch commented 1 year ago

I am unable to look through which of these hundreds of mods is causing the issue. Please help pinpointing which one is causing the problem, otherwise the issue is non actionable and closed. (Just for reference: not all modpacks experience this issue)

I understand, but i dont know which mod is causing the problem... I am trying to figure out but i am not a dev... I thought you could help me with this... I Saw some people with this problem on the comments of the mod (But they think that simplyswords are causing the lag).

I cant tell you which one is causing this problem. Do you think the performance mods are causing the lag? do you have any idea of what i can test to check which mod is causing this? (I would try any)

ZsoltMolnarrr commented 1 year ago

To pinpoint which mod is causing this, try disabling your mods manually until you see the error gone, in a binary search method, (binary search will take the least amount of action).

I have zero idea which mod is causing this problem. Most usual candidate is Optifine. Sodium and Iris don't cause this.

Zaatch commented 1 year ago

To pinpoint which mod is causing this, try disabling your mods manually until you see the error gone, in a binary search method, (binary search will take the least amount of action).

I have zero idea which mod is causing this problem. Most usual candidate is Optifine. Sodium and Iris don't cause this.

Ok, i will try remove 1 by 1, when i see the error gone i ll be back here. Thanks!

ZsoltMolnarrr commented 1 year ago

Ok, i will try remove 1 by 1, when i see the error gone i ll be back here. Thanks!

1 by 1 takes lots of time, I recommend binary search. https://www.youtube.com/watch?v=MFhxShGxHWc

Zaatch commented 1 year ago

To pinpoint which mod is causing this, try disabling your mods manually until you see the error gone, in a binary search method, (binary search will take the least amount of action). I have zero idea which mod is causing this problem. Most usual candidate is Optifine. Sodium and Iris don't cause this.

Ok, i will try remove 1 by 1, when i see the error gone i ll be back here. Thanks!

I finded! Its "Emotecraft". When i remove this mod, the game starts to works properly.

ZsoltMolnarrr commented 1 year ago

Thank you for the information!

Zaatch commented 1 year ago

Thank you for the information!

Thank you for the patience

ZsoltMolnarrr commented 1 year ago

Using the following mod versions I am unable to reproduce the issue in single player:

Better Combat [Fabric & Forge]
daedelus_dev
bettercombat-fabric-1.7.1+1.19.jar

Cloth Config API (Fabric/Forge)
shedaniel
cloth-config-8.2.88-fabric.jar

Emotecraft (Fabric)
KosmX
emotecraft-for-MC1.19.2-2.2.5-fabric.jar

Fabric API
modmuss50
fabric-api-0.76.0+1.19.2.jar

MC Dungeons Weapons
chronos_sacaria
mcdw-5.0.11-1.19.jar

playerAnimator
KosmX
player-animation-lib-fabric-1.0.2.jar

Sodium
jellysquid3_
sodium-fabric-mc1.19.2-0.4.4+build.18.jar

Are you sure you have updated all mods to the latest version? Is this effecting multiplayer only?

Zaatch commented 1 year ago

This happens on Single Player too I am using 200+ mods, but only when i remove "Emotecraft" the game starts to work properly. I just used AT Launcher to update every single mod i use, and the problem continues...

ZsoltMolnarrr commented 1 year ago

What version of Emotecraft are you using?

Zaatch commented 1 year ago

Same as you, 2.2.5

Zaatch commented 1 year ago

i tested with the beta too, 2.2.7

ZsoltMolnarrr commented 1 year ago

Can you reproduce the issue with the release version 2.2.5?

Zaatch commented 1 year ago

I was using the 2.2.7 version before.***

Reproducing: image image

without holding two-handed weapon image

holding two-handed weapon image

holding one-handed weapon image

My new tests presents: 277 Without holding two-handed weapon 217 holding two-handed weapon (60 fps loss) 273 holding one-handed weapon (4 fps loss / no problem)

ZsoltMolnarrr commented 1 year ago

I was still unable to reproduce the issue with the mentioned mods. If you install Better Combat, Emotecraft, Sodium and Iris only, does the issue occur?

LokiLingerin commented 1 year ago

it looks like it has something to do with player models, im using shoulder surfing and first person player model + alex's armoury and the issue also is ocurring. i believe it may have something to do with the hands as well, since with two handed weapons the issue is most prevalent, it also happens when atacking a single handed weapon

single handed weapon not atacking 2023-06-12_10 51 08

single+atacking 2023-06-12_10 51 19

2 hand not atacking 2023-06-12_10 51 27

2 hand atacking 2023-06-12_10 51 27

LokiLingerin commented 1 year ago

plus it also seems to happen when using an emote, its probably an incompatibility with player animator (?) 2023-06-12_11 02 25

ZsoltMolnarrr commented 1 year ago

I am still unable to reproduce this issue. Please specify the minimal mod setup, with a specific scenario to reproduce it.

luan-digital commented 10 months ago

Hello,

I was having the same issue, and it's very bad when playing with friends on my server, as whenever someone attacks, my FPS will go down significantly. After doing some tests, it appears that the issue is indeed something related to Emotecraft, but this problem is more noticeable in third person, wearing armor and when shaders are enabled with Iris.

Here's a little video I recorded showing how the FPS drops from around 90 down to 60 when attacking in third person wearing armor, with smaller drops without amor. Note that the armor is invisible due to another mod, but I also recorded another video without many of my mods and there's still a drop from around 100 fps to 90 when wearing armor versus no drop without armor (10 fps isn't a big deal, but the frametimes get all messed up, so it's very noticeable. I think this number is also smaller because I recorded in a superflat world).

Both videos were recorded in Minecraft 1.19.2 Fabric 0.14.22 and 0.14.23. Mod list (from the second video, where there are way fewer mods but the issue is still present):

ZsoltMolnarrr commented 10 months ago

Thank you this is useful information, however more specifics are needed. Does the problem happen without EmoteCraft? Which is the absolute fewest set of mods to reproduce this problem?

luan-digital commented 10 months ago

Hey, thanks for the reply. I did some other tests now and this only happens with EmoteCraft installed, and I was able to reproduce the issue with this minimal set of mods as well:

The shaders I tested this with are Complementary Shaders Reimagined, Nostalgia and Solas.

I think it's important to note again that the issue seems to get worse when the player is wearing armor, and that I only had issues in third person or when another player is visible while attacking.

K0rS1z commented 6 months ago

Hello everyone, I join in the discussion of this issues. There is a modpack with more than 200 mods on forge (writes one of the modpack developers). The modpack has all these mods:

Embeddium is used instead of Sodium. Some players (not all) have strong FPS drawdowns when they pick up a weapon (even an ordinary sword or axe) or when interacting with it. Surprisingly, the issue may not occur immediately, but after a while.

I will do the testing and write about the result later. (Sorry for my English)

K0rS1z commented 6 months ago

Tests have shown that removing the mod "API-bendy-lib-forge-2.1.1.jar " solves the issue.