search

ZsoltMolnarrr / BetterCombat

⚔️ Easy, spectacular and fun melee combat system from Minecraft Dungeons.
https://www.curseforge.com/minecraft/mc-mods/better-combat-by-daedelus
Other
129 stars 49 forks source link

Swapping any two-handed weapon from offhand slot to hotbar voids the weapon #348

Closed AlisonHuang777 closed 6 months ago

AlisonHuang777 commented 6 months ago

Minecraft version - 1.20.1 Mod loader - NeoForge 47.1.99 Mod version - Fabric 1.8.4, using Sinytra Connector 1.0.0-beta.32 I am using the latest version available - Kind of

Describe the bug As the title described.

To Reproduce Steps to reproduce the behavior:

  1. Put any two-handed weapon in the offhand slot.
  2. Swap the weapon to hotbar. (by pressing F by default)
  3. The weapon disappears.

Expected behavior The weapon should not disappear.

Screenshots or video recordings

https://github.com/ZsoltMolnarrr/BetterCombat/assets/51637996/0a372968-1c58-4b34-9cc0-880cf0dbbf29

Additional context Playing Prominence II Classic modpack (v2.6.0).

ZsoltMolnarrr commented 6 months ago

Use Forge specific version, which has this issue fixed.

AlisonHuang777 commented 6 months ago

Then can you make this mod compatible with NeoForge? The latest version of this mod (for Forge) requires the Forge version to be at least 47.2.0, but NeoForge does not (yet) reach such version number.

ZsoltMolnarrr commented 6 months ago

1.8.0 can be used with NeoForge image

ZsoltMolnarrr commented 6 months ago

Dedicated NeoForge support will be added in the future.

AlisonHuang777 commented 6 months ago

Thank you!