search

ZsoltMolnarrr / BetterCombat

⚔️ Easy, spectacular and fun melee combat system from Minecraft Dungeons.
https://www.curseforge.com/minecraft/mc-mods/better-combat-by-daedelus
Other
129 stars 49 forks source link

Incompatibility with Balkon's Weaponmod: Legacy #377

Closed DragonacyCX closed 1 month ago

DragonacyCX commented 3 months ago

Minecraft version - 1.20.1 Mod loader - Forge Mod version - 1.8.5 + 1.20.1 I am using the latest version available - yes

Describe the bug When trying to join a world with both mods installed, the game crashes.

To Reproduce Steps to reproduce the behavior:

  1. Add "Better Combat 1.8.5 + 1.20.1" and "Balkon's Weaponmod: Legacy 1.20.1-1.21.0
  2. Launch the modded game
  3. Try to join a world
  4. See error: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "attributeId" is null

Expected behavior I expected the game to work normally with these two mods

Screenshots or video recordings If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

ThexXTURBOXx commented 2 months ago

I have fixed this myself in #378. However, the fix has not yet been published. Also @ZsoltMolnarrr: my fix has not yet been ported to other versions of Better Combat - only 1.20.1. However, it also affects other versions as well. These should receive the same treatment :)

ZsoltMolnarrr commented 1 month ago

Fix released as part of BetterCombat 1.8.6

Feel free to reopen if the issue resurfaces.