search

ZsoltMolnarrr / CombatRoll

🧶 Adds combat roll ability, with related attributes and enchantments.
https://www.curseforge.com/minecraft/mc-mods/combat-roll
GNU General Public License v3.0
17 stars 14 forks source link

[Bug report] combatroll:count 0 allows one roll #14

Closed e3valdas closed 1 year ago

e3valdas commented 1 year ago

Minecraft version - 1.19.2 Mod loader - Fabric 0.14.10 Mod version - 1.0.8 I am using the latest version available - yes.

Describe the bug Setting attribute combatroll:count to 0 is the same as setting it to 1 (default).

To Reproduce Steps to reproduce the behavior:

  1. Run command /attribute @s combatroll:count base set 0
  2. Attempt to roll.

Expected behavior Doing this should take away player's ability to roll.

ZsoltMolnarrr commented 1 year ago

Interesting find, I will investigate whenever I have time.

ZsoltMolnarrr commented 1 year ago 
public static final EntityAttribute COUNT = (new ClampedEntityAttribute("attribute.name.combat_roll." + countName, 1, 1, 20.0)).setTracked(true);

(min = 1)