ZsoltMolnarrr / SpellPower

🔮 Spell Power entity attribute for magical abilities and items
https://www.curseforge.com/minecraft/mc-mods/spell-power
GNU Lesser General Public License v3.0
10 stars 7 forks source link

[1.20.1][Bug] Conflicting mods override enchantment conditions #12

Open Rav115 opened 11 months ago

Rav115 commented 11 months ago

With your mod active i can get like sword enchantments on bow boot enchants on chestplate etc.. also i disabling your mod works fine and i dont get them on wrong tools i was using your (0.9.18+1.20.1-fabric) version image

ZsoltMolnarrr commented 11 months ago

When this mod is installed alone (or with any other mods of mine) no such issue happens, hence it is very likely this is some kind of conflict between mods. I would be greatly helpful which specific other mod is this one conflicting with.

Rav115 commented 11 months ago

i guess it really is just those 2 mods but felt like more but now when testing cant seem to get other mods

https://modrinth.com/mod/wall-jumped https://www.curseforge.com/minecraft/mc-mods/amethyst-imbuement

ZsoltMolnarrr commented 11 months ago

Spell Power Attributes is a standalone project, not just Wizards mod is using it. For example:

Any other mod that wants to integrate with RPG Series, by adding equipment can use this, without relying on the entire Spell Engine.

How exactly could I guarantee the correct behaviour of enchantment conditions if another mod is overriding mines?

ZsoltMolnarrr commented 11 months ago

I am asking everyone on this thread to remain purely assertive.

Healock commented 8 months ago

2024-01-12_02 23 39_proc dont know whats going on..

im using:

ZsoltMolnarrr commented 8 months ago

There is definitely something fishy going on with the underlying logic of the included enchantment API.

JoshS-dev commented 7 months ago

Any new revelations for this issue? This is also happening with my 1.20.1 modpack, and despite it being quite large I do not have any mods that affect how enchanting works other than Easy Magic and Tax Free Levels, and the issue still persists with it disabled.

Example being a pickaxe being enchanted in the enchanting table is being given Spell Volatility and enchantments of its ilk, which would be pointless to a pickaxe as it is not a magical weapon and surely does not have the MAGICAL_WEAPON tag as described in the enchantments.json.

ZsoltMolnarrr commented 7 months ago

The enchantment API within this mod is due to rewrite. I don't see any alternatives, because there is no obvious resolution.