Hyperlinks are not shown properly

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Skin the installer using the 'Carbon.vsf' (I don't tested others)
2. Create an rtf document that contains an hyperlink to an url or to an email 
(MailTo:XXX@xxx.com)
3. Set the document to show in in the installer:
InfoBeforeFile=...\InfoBefore.rtf
4. Compile the installer and see how the hyperlinks are black, are unable to 
see them.

What is the expected output?
I expected a way in the VCL Styles designer to set the desired hyperlink color 
in a theme, or at least a default Hyperlink colour that can be legible.

What do you see instead?
A black hyperlink text color.

What version of the product are you using?
The one that is provided in the main page: http://goo.gl/Exkewk
"The current version of the plugin is 1.2.9.5 release Date 20141029"

On what operating system?
Windows 8.1 x64

Please provide any additional information below.

Here is an image demostrating the problem: http://i.imgur.com/V8xHIm8.png

Here you can download my installer source ready to compile, with the RTF 
document: https://www.mediafire.com/?61n3r4tfx3xio88

I attached both files in this post.

Original issue reported on code.google.com by ElektroS...@elhacker.net on 12 Nov 2014 at 12:59

Attachments:

• [Captura 1.png](https://storage.googleapis.com/google-code-attachments/vcl-styles-plugins/issue-12/comment-0/Captura 1.png)
• [CronoX.exe Setup.rar](https://storage.googleapis.com/google-code-attachments/vcl-styles-plugins/issue-12/comment-0/CronoX.exe Setup.rar)

[GoogleCodeExporter]

The hiperlink colors are handled directly for the OS. So is not possible modify 
the color of such element.

Original comment by Rodrigo.Ruz.V@gmail.com on 15 Nov 2014 at 2:39

• Changed state: WontFix

[GoogleCodeExporter]

No, the style changes the hyperlink color.

As default an hyperlink appears with BLUE color, that is the color that I see 
when editing the RTF document in wordpad for example.

Since using the carbon.vsf style the hyperlink appears with a BLACK color that 
means something is wrong with the style because is not showing the default 
system color for an hyerlink, its totally black.

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 9:53

[GoogleCodeExporter]

Why discarded so fast this issue?, I don't pretend to offend but... h ave you 
tried it?.

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 9:55

[GoogleCodeExporter]

Sorry for this, but I received a very similar issue report on the past related 
to the color of the hiperlinks, but on that case was another control not and 
the TRichEditViewer, I just fixed the issue, try the new version 1.3.2.1 and 
let me know the results.

Original comment by Rodrigo.Ruz.V@gmail.com on 15 Nov 2014 at 3:43

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for your interest about fix this bug, but unfortunately the problem is 
not fixed, the hyperlinks still shown with black forecolor while out of 
InnoSetup my Hyperlinks are blue :-/

I just used the same source that I attached in the post above, but changing the 
old carbon.vsf for the new one.

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:00

[GoogleCodeExporter]

Also I think it could be a good idea to put an hyperlink example in the "VCL 
Style Viewer" to see the changes at design time.

PS: Are you Spanish?

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:05

[GoogleCodeExporter]

Setting the syscolor clHighlighttext to white does not take any effect.

but if you alternate ALL the colors and syscolors to a NON-BLACK color and then 
set the clHighlighttext it works... omg, there is a big conflict with the 
colors of this theme! I hope you could find it and fix it.

thanks

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:24

[GoogleCodeExporter]

the "clHighlighttext" is the one that can change the hyperlink color, but is a 
nightmare to make it work (also it comes as Black color by default for this 
theme... that should be fixed too), I'm trying to alternate all other colors to 
finf evidences of the other conflictive color or syscolor... but no way.

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:28

[GoogleCodeExporter]

I just tested your sample script (replacing the unins000.dll file) and works 
fine. 

Original comment by Rodrigo.Ruz.V@gmail.com on 15 Nov 2014 at 6:34

Attachments:

• CronoX.png

[GoogleCodeExporter]

I did just the same and didn't worked, Ok then something occurs in your side or 
in my side, maybe you could try in an VirtualMachine?, replacing does not wrk 
for me, but also there is a bug related to thhe colours, steps to reproduce the 
"bug?":

1. Download the latest VSL for inno version and install it
2. Open the designer and load the new carbon.vsf
3. set the clHighlight and clHighlightText to any other color, in this example 
Green, and save the theme.
4. Compile an inno setup source that displays an RTF document with hyperlinks
   At this points the hyperlinks are not using the new color (green), are black.

And, steps to solve this hyperlinks issue in a weird way:
1. Open the designer and load the new carbon.vsf
2. Select all the normal colors (holding shift key) to set a White color for 
all.
3. Do the same as step 2 but with the Syscolors of the theme
4. Now, set the clHighlightText to any other color, Pink for example.
5. Compile an inno setup source that displays an RTF document with hyperlinks
   At this points the hyperlinks are using the new color, Pink in this case.

Is so strange

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:50

[GoogleCodeExporter]

sorry for my misstypes, i hope you could understand right.

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 6:52

[GoogleCodeExporter]

See this video of 1 min duration please, I demonstrate that it does not work 
(for me) just replacing the new version.

Also I demonstrate the weird way to work the hyperlink alternating all the 
other colors, as I said is strange... there is something wrong with that color 
and the rest of colors in the theme.

http://www.youtube.com/watch?v=izFzNUbtAMA

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 7:01

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This is the script code of your project, which I use, even the compiled project 
is included https://dl.dropboxusercontent.com/u/12733424/CronoX.zip . Also you 
don't need modify the colors of the style. because the fix was made to the 
plugin code. 

Original comment by Rodrigo.Ruz.V@gmail.com on 15 Nov 2014 at 7:05

[GoogleCodeExporter]

I compiled the source that you provided, yes it works.

Then now is more clear what happened:

You have put by error a non-fixed carbon.vsf in the new VCL-Styles update 
release for download.

the filesize of the carbon.vsf is different:

· filesize of the carbon.vsf included in the new vcl-styles installer is:
49.297 bytes

· filesize of the carbon.vsf included in the source that you uploaded to 
dropbox is:
49.314 bytes

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 7:10

[GoogleCodeExporter]

Sorry, i will rectify
all was my fault from the start

I didn't noticed that I also should update/replace the VclStylesinno.dll to get 
it work, if I don't replace the dll the carbon.vsf does not load properly for 
the hyperlinks.

sorry about missing that detail, what a fail

very thanks for your time, yes this is totally fixed, thanks again

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 7:16

[GoogleCodeExporter]

I just thinked that the new version update of VCL-Styles was only to fix this 
issue with the carbon.vsf then I didn't noticed the dll, I'm very sorry for 
loosing your time.

great software!

Original comment by ElektroS...@elhacker.net on 15 Nov 2014 at 7:18

[GoogleCodeExporter]

No problem. Thanks for testing and using the plugin. remember mark the star 
this project ;)

Original comment by Rodrigo.Ruz.V@gmail.com on 15 Nov 2014 at 7:19