Error-Handling is too intrusive

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Set up the uninstaller skin with the VclStylesInno.dll.
2. Install the application, and delete the VclStylesInno.dll from its install 
location.
3. Run the uninstaller, and a disturbing error msgbox will appear.

What is the expected output? What do you see instead?
I expected to see nothing, this FileNotfound exception should be raised by the 
dll to be catched by the end user, I should decide whether to show or not an 
advertising msgbox, I think that this error-handling of VclStylesInno.dll is 
not following in generally good developing practices.

I can't find the way to ignore the error, because maybe is not possible to 
ignore that msgbox as it is developed to show that msgbox (and maybe there is 
other msgboxes in other exceptions, I think all should be changed/deleted for a 
release version of the dll).

Please provide any additional information below.

Please, see this question with the code that I've used to understand all:
http://stackoverflow.com/questions/27084812/ignore-error-message-of-error-handli
ng?

I've solved it by using FileExists function but that is not what I'm reffering 
in this issue.

I would like to remark this comment of that url from a very pascal-script 
expert that always give me help and hints for my inno-setup scripts:

'...DLLs must not raise any exception, but should not show any dialogs when 
they encounter some...'

I'm totally accord with him.

Thanks for read and please considerate this!

Original issue reported on code.google.com by ElektroS...@elhacker.net on 23 Nov 2014 at 11:32

Attachments:

• KXQZm.png

[GoogleCodeExporter]

Original comment by Rodrigo.Ruz.V@gmail.com on 24 Nov 2014 at 2:42

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r35.

Original comment by Rodrigo.Ruz.V@gmail.com on 24 Nov 2014 at 3:01

• Changed state: Fixed

[GoogleCodeExporter]

This suggestion was added. Check the new version of the plugin (1.3.2.9)

Original comment by Rodrigo.Ruz.V@gmail.com on 24 Nov 2014 at 3:03

[GoogleCodeExporter]

You missed one MessageBox call (just the one for which this was reported :-)

https://code.google.com/p/vcl-styles-plugins/source/browse/trunk/InnoSetup+plugi
n/VclStylesInno.dpr?spec=svn35&r=35#62

Original comment by tlama.ex.2@gmail.com on 24 Nov 2014 at 4:37

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

omg TLama you are everywhere :P

Then waiting for that fix on that msgbox call.

Thanks the author for considerate this issue, and forgive my "bad" words, my 
english is not very good.

Thanks TLama for the help too.

Original comment by ElektroS...@elhacker.net on 24 Nov 2014 at 4:42

[GoogleCodeExporter]

Ok, now was fixed. check the last version 1.3.3.0

Original comment by Rodrigo.Ruz.V@gmail.com on 24 Nov 2014 at 4:52