Unsigned 32-bit integers stored correctly in BitcoinBlock

ZuInnoTe / hadoopcryptoledger

Hadoop Crypto Ledger - Analyzing CryptoLedgers, such as Bitcoin Blockchain, on Big Data platforms, such as Hadoop/Spark/Flink/Hive

Apache License 2.0

141 stars 51 forks source link

Unsigned 32-bit integers stored correctly in BitcoinBlock #74

Closed phelps-sg closed 3 years ago

phelps-sg commented 3 years ago

Introduced a new class LittleEndianUInt32 for storing little-endian unsigned 32-bit integers. This class allows the unsigned value to be retrieved as a long on-demand, thus allowing the full range of unsigned values without taking up any additional space, thus addressing issue #70.
Reformatted code to adhere to style guidelines.
Fixed javadoc comment format and dangling javadoc.
Added methods getEpochTime and getDate to BitcoinBlock.

jornfranke commented 3 years ago

thank you. I will need more time to check this There is also a lot of implications on HiveSerde, Spark Datasource etc. It looks like breaking compatibility a lot for those.

phelps-sg commented 3 years ago

I have run all the unit tests and they all pass. Are there other testing tools I should have run? If there are issues your side can you please add unit tests or other automated tests to illustrate the problem. If you do not provide the test framework then I have no way of knowing of whether my changes break anything. On the other hand if you provide a comprehensive test suite then I can test everything before I push.

Sent from ProtonMail mobile

-------- Original Message -------- On 11 Oct 2020, 20:23, Jörn Franke wrote:

thank you. I will need more time to check this There is also a lot of implications on HiveSerde, Spark Datasource etc. It looks like breaking compatibility a lot for those.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jornfranke commented 3 years ago

Unfortunately the CI system broke (unrelated to the pull requests), I will look into this. The test suite is already included with the HiveSerde and the Spark DataSource. Did you run those on a version of the hadoopcryptoledger library including your changes (deployed to a local maven with the new version as a dependency)? I still have to check and verify everything and will come back.

phelps-sg commented 3 years ago

Did you run those on a version of the hadoopcryptoledger library including your changes (deployed to a local maven with the new version as a dependency)?

Apologies- no I haven't run these tests. How do I run the integration tests? I checked the contributing guidelines but couldn't find the info there.

jornfranke commented 3 years ago

closed due to detached fork