search

ZuInnoTe / hadoopcryptoledger

Hadoop Crypto Ledger - Analyzing CryptoLedgers, such as Bitcoin Blockchain, on Big Data platforms, such as Hadoop/Spark/Flink/Hive
Apache License 2.0
141 stars 51 forks source link

The comment with the Apache License should be a block comment not a javadoc comment #76

Closed phelps-sg closed 3 years ago

phelps-sg commented 3 years ago

Each source files begins with 

/**
* Copyright 2017 ZuInnoTe (Jörn Franke) <zuinnote@gmail.com>
*
...
*/

In the IntelliJ IDE this generates a static warning "Dangling Javadoc comment".

The comment should be a block comment, not a javadoc comment, ie:

/*
 * Copyright 2017 ZuInnoTe (Jörn Franke) <zuinnote@gmail.com>
 *
...
 */
jornfranke commented 3 years ago

Please do not work on any issues before it has been agreed and discussed. Otherwise we cannot accept pull requests.

phelps-sg commented 3 years ago

I am using this library in my own project, which has its own requirements and deadlines, so I may need to work on issues quickly. I will continue committing to my forked repo. If you do not want my pull requests that is your prerogative. I will try not to issue PRs until you have ok-ed the issue, but note that this may result in divergence of the fork.

jornfranke commented 3 years ago

Ok, I propose that you finish your project in your repo and then we can see later to integrate it. Maybe then we can simplify the things as well a bit. I probably will not have the time to review it within your deadlines and I do not want to block you