ZuInnoTe / hadoopcryptoledger

Hadoop Crypto Ledger - Analyzing CryptoLedgers, such as Bitcoin Blockchain, on Big Data platforms, such as Hadoop/Spark/Flink/Hive
Apache License 2.0
141 stars 51 forks source link

Some javadoc comments incorrectly written as block comments #78

Closed phelps-sg closed 3 years ago

phelps-sg commented 3 years ago

Throughout the code there are block comments which should be javadoc comments, e.g. in BitcoinAuxPOW:

        /*
     * Creates an empy AuxPOW object in case the feature is not used (e.g. in the main Bitcoin blockchain)
     * 
     */
    public BitcoinAuxPOW() {
        this.version=0;
        this.coinbaseTransaction=null;
        this.coinbaseBranch=null;
        this.auxBlockChainBranch=null;
        this.parentBlockHeader=null;
    }

which should be:

       /**
     * Creates an empy AuxPOW object in case the feature is not used (e.g. in the main Bitcoin blockchain)
     * 
     */
    public BitcoinAuxPOW() {
        this.version=0;
        this.coinbaseTransaction=null;
        this.coinbaseBranch=null;
        this.auxBlockChainBranch=null;
        this.parentBlockHeader=null;
    }
jornfranke commented 3 years ago

Please do not work on any issues before it has been agreed and discussed. Otherwise we cannot accept pull requests.