ZuInnoTe / hadoopcryptoledger

Hadoop Crypto Ledger - Analyzing CryptoLedgers, such as Bitcoin Blockchain, on Big Data platforms, such as Hadoop/Spark/Flink/Hive

Apache License 2.0

141 stars 51 forks source link

Refactor code smells #88

Closed BennyDanielT closed 2 years ago

BennyDanielT commented 2 years ago

Refactored Code Smells

[ ] Long Method - Commit #: 8683a997bac22c51568337326664e1a52b59eeb1
[ ] Typographical Errors - Commit #: 3e54e78c2113674325e0272ea732aff7527b3635
[ ] Cyclically-dependent Modularization - Commit #: bd7fe898b4d1130eed6f02a58ff720196d2d846a
[ ] Multifaceted Abstraction - Commit #: f682830b65bd34f438d48d00dd4a7c507ac4f570
[ ] Duplicated Code Blocks - Commit #: 2da51bffaa6e3b19993f23cf62d26c0f877ff008

BennyDanielT commented 2 years ago

The following items were changed:

Pull-Up Method to Abstract Class to remove Code Duplication:

Classes Involved:

flinkdatasource/src/main/java/org/zuinnote/flink/bitcoin/AbstractBitcoinFlinkInputFormat.java
flinkdatasource/src/main/java/org/zuinnote/flink/bitcoin/BitcoinBlockFlinkInputFormat.java
flinkdatasource/src/main/java/org/zuinnote/flink/bitcoin/BitcoinRawBlockFlinkInputFormat.java
flinkdatasource/src/main/java/org/zuinnote/flink/bitcoin/BitcoinTransactionFlinkInputFormat.java

Rename Variables that contain typos:

inputformat/src/main/java/org/zuinnote/hadoop/bitcoin/format/mapred/AbstractBitcoinFileInputFormat.java
1. Rename CONF_ISSPLITABLE to CONF_IS_SPLITTABLE
2. Rename DEFAULT_ISSPLITABLE to DEFAULT_IS_SPLITTABLE
inputformat/src/main/java/org/zuinnote/hadoop/bitcoin/format/mapreduce/AbstractBitcoinFileInputFormat.java
1. Rename CONF_ISSPLITABLE to CONF_IS_SPLITTABLE
2. Rename DEFAULT_ISSPLITABLE to DEFAULT_IS_SPLITTABLE

Extract a large method into smaller methods:

inputformat/src/test/java/org/zuinnote/hadoop/ethereum/format/common/EthereumFormatReaderTest.java Method:
1. parseBlock1346406AsEthereumBlockHeap
2. parseBlock1346406AsEthereumBlockDirect

Resolve Cyclic Dependency between EthereumTransaction & EthereumUtil by introducing an Interface and making EthereumUtil implement it

inputformat/src/main/java/org/zuinnote/hadoop/ethereum/format/common/EthereumTransaction.java
inputformat/src/main/java/org/zuinnote/hadoop/ethereum/format/common/EthereumUtil.java New Interface: inputformat/src/main/java/org/zuinnote/hadoop/ethereum/format/common/EthereumTransactionInterface.java

Extract a class that has a high Lack of Cohesion among Methods (LCOM) value and decompose it into cohesive classes

Class Decomposed - inputformat/src/test/java/org/zuinnote/hadoop/ethereum/format/common/EthereumUtilTest.java New Classes:

inputformat/src/test/java/org/zuinnote/hadoop/ethereum/format/common/EthereumUtilBlockTest.java
inputformat/src/test/java/org/zuinnote/hadoop/ethereum/format/common/EthereumUtilDecodeTest.java
inputformat/src/test/java/org/zuinnote/hadoop/ethereum/format/common/EthereumUtilEncodeTest.java