search

Zubax / kocherga

Robust platform-agnostic Cyphal/DroneCAN bootloader for deeply embedded systems
https://zubax.com
MIT License
45 stars 10 forks source link

kocherga_serial: update header format #26

Closed coderkalyan closed 5 months ago

coderkalyan commented 6 months ago

Fixes #22

pavel-kirienko commented 6 months ago

I think it is best to move CRCs into the common header -- kocherga.hpp -- because they will be used in the Cyphal/UDP transport as well. Maybe there are some other common parts here.

coderkalyan commented 6 months ago

Ok, will do. I'll ping you when it's actually ready, tests aren't passing right now.

coderkalyan commented 5 months ago

@pavel-kirienko This should be ready for review now. Sorry it took so long.

coderkalyan commented 5 months ago

@pavel-kirienko I don't think the CI is running automatically.

pavel-kirienko commented 5 months ago

I don't think the CI is running automatically.

ok it should now

coderkalyan commented 5 months ago

Thanks, everything is good now except for sonarcloud (not sure what's wrong exactly, but doesn't seem to be related to the code).

coderkalyan commented 5 months ago

Thanks. Just pushed the updated test.