Zubnix / skia-wasm-port

Port of the Skia drawing library to wasm, for use in javascript (node & browser)
MIT License
174 stars 13 forks source link

Awesome work! #1

Open reed-at-google opened 6 years ago

reed-at-google commented 6 years ago

Very impressed. Would love to hear any problems or complaints you have with Skia; changes we could do to make this library easier to build and/or smaller/faster.

Mike Reed reed@google.com

Zubnix commented 6 years ago

Thanks for the heads up!

As for suggestions: The first thing that comes to mind is I had to make some changes to the original skia build script to get some options disable/enabled that were automatically enable/disable on linux but were needed when compiling to wasm (llvm bitcode actually). I'll see if I can diff them (it's been a while since I worked on this port). Would you like me to put them here, or as a separate bug on the skia project site?

reed-at-google commented 6 years ago

Hi Erik,

Maybe a separate bug, so we can easily track (several of) them.

Did you try to use the GL backend at all, or just the raster one? Any obviously hunks of code you wish you could have skipped (to reduce the binary size)? Do you think a deliberate C-api (maintained by us) would be better than just binding to the C++?

As you can tell, we're pretty interested in skia-on-webasm, and are impressed that you've already done it.

mike

On Tue, May 22, 2018 at 4:53 PM Erik De Rijcke notifications@github.com wrote:

Thanks for the heads up!

As for suggestions: The first thing that comes to mind is I had to make some changes to the original skia build script to get some options disable/enabled that were automatically enable/disable on linux but were needed when compiling to wasm. I'll see if I can diff them (it's been a while since I worked on this port). Would you like me to put them here, or as a separate bug on the skia project site?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Zubnix/skia-wasm-port/issues/1#issuecomment-391136981, or mute the thread https://github.com/notifications/unsubscribe-auth/AMa7ojEePSFsQVKi9WGcjAMKe0V4tWGmks5t1HrEgaJpZM4UJPjk .

Zubnix commented 6 years ago

Hi reed,

I did not try the GL backend, although I would really like to plug skia into webgl.

Ideally :unicorn: I'd like to have skia render in an offscreen webgl canvas in a webworker. But that's mostly because of my own personal agenda :wink:

I've created a quick gist of the changes I did to give you some idea: https://gist.github.com/Zubnix/8e63ee2e0f1ceffc9ad266596d5f5197

There are basically 2 changes.

A deliberate C-api would absolute make things much easier when creating bindings. :+1:

Zubnix commented 6 years ago

Relevant discussion: https://bugs.chromium.org/p/skia/issues/detail?id=8041