Zuehlke / poinz

Distributed Planning Poker
MIT License
141 stars 62 forks source link

Docker hub tags 0.17.x are missing #284

Closed egonzalezgmv closed 2 years ago

egonzalezgmv commented 2 years ago

Hi,

Since a few releases ago, Docker hub image tags are not being generated, last published tag was 0.16.0: https://hub.docker.com/r/xeronimus/poinz/tags?page=1&name=0.16.

All 0.17.x are missing: https://hub.docker.com/r/xeronimus/poinz/tags?page=1&name=0.17.

Master release is well published as latest nevertheless: https://hub.docker.com/r/xeronimus/poinz/tags?page=1&name=latest

Thank you

xeronimus commented 2 years ago

Hi,

thanks for opening this issue. Currently I need to manually trigger the github action on the specific git tag (e.g. "0.17.3") on the master branch. The docker image will be then correctly tagged with the git tag of the respective commit.

(I forgot to do that for the 0.17.x, I just triggered it for 0.17.3 and Docker hub correctly lists it https://hub.docker.com/r/xeronimus/poinz/tags?page=1&name=0.17 )

Any ideas how to automatically trigger the github action, if I publish a new release (and also tag the latest master commit) through the github UI?

Maybe we need to adjust our github action /.github/workflows/master.yml

name: master

on:
  workflow_dispatch:
  push:
    branches:
      - master

to

name: master

on:
  workflow_dispatch:
  push:
    branches:
      - master
    tags:
      - '*'

would that do the trick?

ociotec commented 2 years ago

Thanks a lot!