search

Zuehlke / zuehlke.github.io

Zühlke Github Page
http://zuehlke.github.io
10 stars 2 forks source link

Link github profile images #17

Closed kabaehr closed 7 years ago

kabaehr commented 7 years ago

At the moment you have to put an image inside a folder and link to the destination in the people.json. Instead we would like to link the github profile picture directly

bruderol commented 7 years ago

Are you sure this wont work allready?? Maybe you can try my pull request?

bruderol commented 7 years ago

it works now, right? can be closed?

bruderol commented 7 years ago

Thanks @kabaehr - it is great now!

bruderol commented 7 years ago

@kabaehr One last thing. I reopen because it hink something is missing: I propose to change all listed users to allways use their current github profile picture (as it is now for me). Otherwise our users have to maintain their profile picture in two places.

tknerr commented 7 years ago

+1, good idea

kabaehr commented 7 years ago

Done :)