Zuiron / Photosynthesis

MIT License
6 stars 3 forks source link

Cherry leaves turn black with this mod installed #227

Closed Tempest-5ky closed 8 months ago

Tempest-5ky commented 10 months ago

hello! Having an odd issue where installing this mod turns cherry leaf blocks completely black in-world. The item texture is unaffected. image

Minecraft Fabric 1.20.1, mod version 0.0.20

Zuiron commented 10 months ago

Need a full log and mod list

Tempest-5ky commented 10 months ago

Sorry for the delay!

Log: https://mclo.gs/haY5OgD mod list is listed on the log from line 117 to 433

Tempest-5ky commented 9 months ago

update: this seems to affect all of Photosynthesis' leaves image

Zuiron commented 9 months ago

fancy hmm. log doesn't say anything is wrong with my mod. like anywhere... however it does spew errors for other mods. there might be some other mods conflicting with each other which might cause this.

or it might actually be something else, can you try set graphics to fancy for leaves?

Tempest-5ky commented 9 months ago

I’ll look into it via binary search, though I didn’t see any errors relating to photosynthesis leaves when looking through the logs. This is definitely an odd one.

Zuiron commented 9 months ago

can you try with fancy graphics? when you can, I'm curious if that might be the cause xD

Tempest-5ky commented 9 months ago

Unfortunately, that doesn't fix the issue :/ It doesn't seem to be the primary suspects (leaf culling via MoreCulling, or some kind of breakage from PassableLeaves), so I'll do a proper binary search tomorrow to find the suspect.

Zuiron commented 9 months ago

alright, if there is an issue on my end i would really like to know and fix it asap :)

Tempest-5ky commented 9 months ago

I'm so so sorry for the delay- life got busy and I forgot to do this! I can confirm that the issue happens even if Photosynthesis and its dependencies are the only mods loaded. image image

Tempest-5ky commented 9 months ago

The latest.log doesn't seem to show any issues save for some texture, sound, and recipe errors https://mclo.gs/4aTcPkh

Tempest-5ky commented 9 months ago

Ah- alright, when Photosynthesis is the only mod, setting graphics to 'fancy' does fix the issue. Hopefully that helps! If it could be fixed for people with weaker computers that need the graphics on Fast, that would be excellent :D

Tempest-5ky commented 9 months ago

This seems to only partially affect some leaves, and fully affect others. In all cases, it makes the normally transparent sections completely black. I'm aware that this is a normal thing with the 'fast' setting, as vanilla leaves do something similar, though something seems off for those that have gone completely black. Fast graphics: image From left to right: Apple, Banana, Cinnamon, Orange, Pear, Coconut, Avocado, Cherry (all-black), Lemon

Fancy graphics: image

Zuiron commented 9 months ago

ok i know exactly why this is happening now. its because of the custom leaves block with overlay. not sure why its blacked out but. i will definately investigate and see if it can be resolved. thanks for reporting this! its definitely on my end issue.

Zuiron commented 9 months ago

you know what. its actually not possible to fix this per say. the only way to actually fix this. is to bundle an "resource pack" with the season support leaves separately. because the season overlay block ONLY works on fancy leaves.

Zuiron commented 9 months ago

I will actually do that because the season leaves are quiet resource heavy. thanks for this!

Zuiron commented 9 months ago

oh and just to mention it. why its only happening to a few and not others is because the season leaves thing i have only applied to a couple leaves, mainly vanilla and a couple of my own trees just to test it out :P

Tempest-5ky commented 9 months ago

No worries! Thank you sm for the fix :D

Zuiron commented 8 months ago

issue now resolved with latest release. can download now at modrinth: https://modrinth.com/mod/photosynthesis/version/1.20.1-0.0.21

Zuiron commented 8 months ago

oh and. just dont use the optional builtin resoucepack on FANCY graphics. you can now use FAST graphics without issues :)