search

Zukero / andors-trail

Andor's Trail
135 stars 68 forks source link

Fixed a few typos #140

Open byronigoe opened 5 years ago

byronigoe commented 5 years ago

Fixed "the the" and missing a word.

Chriz76 commented 5 years ago

Thank you for the fixes. Did you also include them in weblate? https://hosted.weblate.org/projects/andors-trail/

byronigoe commented 5 years ago

Thank you for the fixes. Did you also include them in weblate? https://hosted.weblate.org/projects/andors-trail/

What do you mean? I don't see English listed at https://hosted.weblate.org/projects/andors-trail/game-content/

Rijackson commented 5 years ago

There is no English on Weblate, because it's the base language. These are good catches. I'm surprised these errors still exist. However, the .pot file is not the right place to fix them. To be honest, I didn't even realize there was an english.pot file until you posted these language errors LOL. You need to go to the folder ...\AndorsTrail\res\raw, which contains many JSON files. All the dialogues are based on these files (and I assume the .pot file is generated from them, although that is nothing more than an assumption on my part). Please fix the errors there.

Chriz76 commented 5 years ago

Sorry for trying to lead into the wrong direction (weblate). Rijackson showed the right way.

byronigoe commented 5 years ago

Okay, should be good to go.

Chriz76 commented 4 years ago

Thank you. I merged your changes to the branch that will be the base for the next release: https://github.com/NutAndor/andors-trail/tree/arulir_mountain