Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 223 forks source link

Error: btoa is not defined #101

Open jbool24 opened 3 years ago

jbool24 commented 3 years ago

I keep getting this error at build time when creating static versions of this Vue app. Not sure what this function/variable is meant to reference.

ReferenceError: btoa is not defined
3:47:47 PM:     at addStyle (/opt/build/repo/node_modules/eagle.js/dist/eagle.cjs.js:444:7)
3:47:47 PM:     at /opt/build/repo/node_modules/eagle.js/dist/eagle.cjs.js:424:12
3:47:47 PM:     at a.__vue_inject_styles__ (/opt/build/repo/node_modules/eagle.js/dist/eagle.cjs.js:482:5)
3:47:47 PM:     at a.hook (/opt/build/repo/node_modules/eagle.js/dist/eagle.cjs.js:397:13)
3:47:47 PM:     at Ft (/opt/build/repo/node_modules/vue/dist/vue.runtime.common.prod.js:6:11191)
3:47:47 PM:     at Ze (/opt/build/repo/node_modules/vue/dist/vue.runtime.common.prod.js:6:25133)
3:47:47 PM:     at a.e._init (/opt/build/repo/node_modules/vue/dist/vue.runtime.common.prod.js:6:32564)
3:47:47 PM:     at new a (/opt/build/repo/node_modules/vue/dist/vue.runtime.common.prod.js:6:30340)
3:47:47 PM:     at Vi (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:66341)
3:47:47 PM:     at io (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:70571)
3:47:47 PM:     at ro (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:70244)
3:47:47 PM:     at _t.eo [as renderNode] (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:67491)
3:47:47 PM:     at _t.next (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:20507)
3:47:47 PM:     at n (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:18719)
3:47:47 PM:     at /opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:68602
3:47:47 PM:     at eo (/opt/build/repo/node_modules/vue-server-renderer/build.prod.js:1:68610)
3:47:47 PM: Done in 35.13s.
esoterra commented 3 years ago

I was able to find the root error. It's an issue with vue-component-compiler itself that prevents SSR from working correctly. https://github.com/vuejs/vue-component-compiler/issues/88

aesdotjs commented 3 years ago

If you encounter this error, or static site generation issues i made a fork that fixes this and enables SSR with eagle.js https://github.com/aesdotjs/eagle.js

Its litteraly 2 lines and 1 package addition (the rest of the commits was to have the dist in git) https://github.com/aesdotjs/eagle.js/commit/967e58383f5cd5e21409a9f7050e64f6eb3b7674

benamar commented 2 years ago

@aesdotjs Do you plan to make a pull request?