Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 222 forks source link

[Safari] Doesn't work some features #3

Closed dimpiax closed 6 years ago

dimpiax commented 7 years ago

Arrows' flow and "Ctrl + right" / left doesn't work. Sliding gesture skippes animation on arrival page.

Zulko commented 7 years ago

Thanks for this. I cant reproduce the arrow problem as I dont have any safari access right now, but i'll have a look first chance i get.

Sliding is not supported right now (because of browser compatibility problems), it's just tapping left or right of the screen.

peterblazejewicz commented 7 years ago

I cant reproduce the arrow problem as I dont have any safari access right now

That's correct (mac OS Sierra/Safari 10.*). I'll dig into this locally

peterblazejewicz commented 7 years ago

Debugged with breakpoints in Safari on Sierra:

dimpiax commented 7 years ago

What if switch to CMD?

dimpiax commented 7 years ago

Try this:

$(window).keydown(function(e) {
  const code = e.keyCode
  if (code === 37 || code === 39) {
    if (e.metaKey) {
      console.log(`slide to ${code === 37 ? 'left' : 'right'}`);
    }
  }
})

Can contribute after lunch ;)

QuentinRoy commented 6 years ago

No need for a new dependency for that! addEventListener('keydown', (e) => { \* ... *\ }); works just as fine.

yaodingyd commented 6 years ago

Please use command + right/left in Mac as ctrl + right/left is move screen by default.