search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 222 forks source link

Can I become a maintainer? #30

Closed yaodingyd closed 6 years ago

yaodingyd commented 6 years ago

@Zulko I have been trying to find your contact but failed to do so, thus I open this issue hoping you could grant my permission to become a maintainer for this project and also the demo project.

I have been actively contributing to this project (issue 18 23 24 25 26 27 28) and also using Vue on work. I believe I could help other people make better use of this wonderful project.

Thank you!

yaodingyd commented 6 years ago

@Zulko thanks!

yaodingyd commented 6 years ago

@Zulko Can I also be a maintainer on eagle.js-demo project? I'm thinking to add more use cases on the demo page.

Zulko commented 6 years ago

Ok. Thanks for your interest by the way. Can you add a "maintainer" section in the readme with your (user)name and mine ?

yaodingyd commented 6 years ago

@Zulko Gladly. Also what's your preferred workflow with collaborators? I intend to do the following:

  1. add throttle and more mobile support to eagle.js
  2. remove vue-route hard-coded part in some components
  3. add tesing and CI

Do I create pull request for you or I can do it on my own? Is there a more effective way to communicate with you?

yaodingyd commented 6 years ago

@Zulko could you get back to me at my last comment at your earliest convenience?

Zulko commented 6 years ago

Sorry, I was away from the Internet.

I agree with your projects 1-2-3.

I don’t intend to work on the core code in the near future so feel free to push directly to master (we can instate pull requests later if more people are working on it at the same time).

I should get back to this project in around 1 month. My future contributions will certainly be satellite projects, such as widgets (timers / autoslides / audio). I may require only minor changes in the core code (such as adding a generic "pluginData" prop to slides, defaulting to {}, to store data for different pugin widgets).

The best way to contact me is via email (you can find my email address using the git log command). If more people are interested, we can also open a page on Gitter for this project.

yaodingyd commented 6 years ago

Thanks!