search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 222 forks source link

`slide` should have default leave style #32

Closed yaodingyd closed 6 years ago

yaodingyd commented 6 years ago

In theme demo page, advance to the third slide, then go back to the second slide, then the second slide would not have any transition effect showing up.

This is because the third slide has 'none' for leave property. This would happen for an even common case when user doesn't set leaveproperty. Because slide is absolute position, later-rendered slide would be on top of previous slide, thus blocking the transition effect.

To fix this we should have a default leave class to hide the slide. Also in documentation should note that if user sets leave, make sure it doesn't block the previous slide's enter transition.

yaodingyd commented 6 years ago

Close this one as added in README.