search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 222 forks source link

Keyboard navigation disables all other keyboard-based browser interaction #37

Closed flesser closed 6 years ago

flesser commented 6 years ago

Is there a reason for evt.preventDefault() in the Slideshow component's keydown handler?

It prevents other keyboard shortcuts from working (like pressing F11 in Firefox to enter/leave fullscreen mode).

I just tested to remove that line in my local copy and have seen no negative side-effects so far.

yaodingyd commented 6 years ago

Good point. I'll look into this further.

yaodingyd commented 6 years ago

It seems the preventDefault is redundant and actually causing some issues (#3).

yaodingyd commented 6 years ago

fixed in 0.1.5