Prevent step over-/underflow

Zulko / eagle.js

A hackable slideshow framework built with Vue.js

https://zulko.github.io/eaglejs-demo/

ISC License

4.08k stars 222 forks source link

Prevent step over-/underflow #38

Closed flesser closed 6 years ago

flesser commented 6 years ago

When using the permalink approach from the Readme, step can sometimes become larger than the actual max step count. Using >= instead of === changes to the next slide nevertheless.

yaodingyd commented 6 years ago

LGTM. Still when implementing permalink, user should have some kinds of router guard because currentSlideIndex can also be out of range. Will update README on this.