search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 223 forks source link

router-link propagates click #59

Closed christianw closed 6 years ago

christianw commented 6 years ago

Before anything else: eagle.js is a fantastic framework!

Having mouseNavigation enabled and using router-link in a template to redirect to another slide, the click is recorded again on the new slide and the next step (in my case the next slide) is shown. I could not find a way to fix this.

Regards Christian

yaodingyd commented 6 years ago

@christianw can you provide a sandbox link?

christianw commented 6 years ago

Thanks for the quick answer. It happens (for me) with every to another slide. The correct slide gets activated, the the click is again captures on this slide and the next slide is shown.

I managed to solve it, though, by using and in this way stopping event propagation. Maybe that's the best way for now and perhaps it could be added in the documentation.

I have made a few other changes like using also ArrowUp/Down and PageUp/Down/Space for navigation to mimick the legacy Powerpoint. I can create a pull request but the changes are trivial anyway.

Again: great fun to work with this!

yaodingyd commented 6 years ago

@christianw any PR is welcome!