Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 223 forks source link

Subslide doesn't update #64

Closed chambas closed 5 years ago

chambas commented 5 years ago

Using the example (https://github.com/Zulko/eaglejs-demo/tree/master/src/slideshows/eagle-recipes), the subslide with the code eg-code-block(lang='html'). doesn't update. No matter what you write in there it always show the first block that it was render.

yaodingyd commented 5 years ago

Demo project will be updated shortly.

chambas commented 5 years ago

And regarding this issue?

yaodingyd commented 5 years ago

Turns out to be a bug. Will fix this later.

yaodingyd commented 5 years ago

https://github.com/Zulko/eagle.js/blob/3c42d5009ee48f65730f6057d615ff096414b6ab/src/components/widgets/CodeBlock.vue#L27

this.update should run in updated life cycle hook too.

yaodingyd commented 5 years ago

Please checkout the latest eaglejs-demo.