search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 223 forks source link

fix(findSlides): option to reset index #76

Closed Oupsla closed 5 years ago

Oupsla commented 5 years ago

Hello folks,

I'm using eagle.js to do a slideshow and I contact an API with a setInterval to add slides progressively so I don't need to reset index of the slideshow Here is a little option of the modified function findSlides to not reset the index

I use JS destructuring instead of simple parameter to let options the possibility to grow without carrying about index of parameter. Also a better option (but breaking change) would be to not set a default value to the resetIndex but I don't take the shot 😆

Happy holidays !

yaodingyd commented 5 years ago

Thanks for your contribution!

yaodingyd commented 5 years ago

ready in 0.4.4