search

Zulko / eagle.js

A hackable slideshow framework built with Vue.js
https://zulko.github.io/eaglejs-demo/
ISC License
4.08k stars 223 forks source link

Check if click event came from keyboard #82 #83

Closed jaylandro closed 5 years ago

jaylandro commented 5 years ago

This is a proposed fix for a click event being emitted by keyboard navigation on a link.

Issue described below https://github.com/Zulko/eagle.js/issues/82#issue-446209408

Zulko commented 5 years ago

Thanks for this! This looks good to me and pretty harmless. @yaodingyd any objections?

yaodingyd commented 5 years ago

LGTM

Zulko commented 5 years ago

@jaylandro it seems that your commit broke the Travis build because of a small cosmetic problem. Can you please fix the syntax until the build passes?

jaylandro commented 5 years ago

@Zulko Fixed. Thanks!

ghost commented 3 years ago

vertical help

ghost commented 3 years ago

@Zulko vertical help