search

Zulko / moviepy

Video editing with Python
https://zulko.github.io/moviepy/
MIT License
12.1k stars 1.51k forks source link

Fix version parsing in setup.py #2010

Closed vanmatten closed 8 months ago

vanmatten commented 12 months ago

The last character of the version is cut out by [:-1] in Path("moviepy/version.py").read_text().strip().split('"')[1][:-1]. Eg: 2.0.0.dev2 become 2.0.0.dev, which Python build reads as 2.0.0.dev0.

In fact Path("moviepy/version.py").read_text().strip().split('"') gives ['__version__ = ', '2.0.0.dev2', ''] so removing the last character isn't needed.

coveralls commented 11 months ago

Coverage Status

coverage: 81.904%. remained the same when pulling fde9ce4c4ef0f00ce9fd0825893e319b4fd33140 on vanmatten:patch-1 into bc8d1a831d2d1f61abfdf1779e8df95d523947a5 on Zulko:master.

keikoro commented 4 months ago

I'm not sure why this was closed/deleted, I can only see that tests failed (not why), did this not solve the problem after all?

vanmatten commented 4 months ago

I'm not sure why this was closed/deleted, I can only see that tests failed (not why), did this not solve the problem after all?

Tests failed as in the main branch when I created the commit and I don't know why. This commit do exactly what I have written in the title, I closed it because the pull request of v2.0 fix this issue as others.

If you think that reopening this pull request is usefull, i'll do it.

keikoro commented 4 months ago

Thanks for the info.

I closed it because the pull request of v2.0 fix this issue as others

If another PR fixes the issue anway, there is indeed no need to reopen this one. Thanks, in any case!