Keyed args passed into write_videofile are being ignored

dsj969 commented 10 months ago

Expected Behavior

Keyword args passed into write_videofile should set the values of those args

Actual Behavior

Keyword args passed into write_videofile are being set to their default values

Steps to Reproduce the Problem

clip = VideoFileClip(srcfile)
clip.write_videofile(srcfile, fps=1)

>> fps is being set as None

Specifications

Python Version: Python 3.10.12
MoviePy Version: 1.0.3
Platform Name: Linux
Platform Version: Ubuntu 22.04.3 LTS

Notes

I believe this issue is specifically tied to decorator v5. In decorator v5 all calls to decorator (eg. @use_clip_fps_by_default) are having their kw args converted to positional args. decorator v5 now includes an argument called 'kwsyntax' within the decorator function, which when set to True retains the keyed args.

bp72 commented 8 months ago

@dsj969 I'm trying to reproduce this using spec and the fps param is passed as it should be. It has been probably a long with other commit.

Can you please confirm that it's not an issue anymore?

keikoro commented 4 months ago

I'm assuming this is a duplicate of #1986? In which case this issue should be closed in favour of the other one.

Zulko / moviepy