search

Zulko / moviepy

Video editing with Python
https://zulko.github.io/moviepy/
MIT License
12.09k stars 1.51k forks source link

Fix typo in docstring #2071

Closed ricqosu closed 4 months ago

ricqosu commented 7 months ago

Fixed typo in doc string

luzpaz commented 4 months ago

Looks correct.

keikoro commented 4 months ago

While improving a docstring's contents, it'd be great to simultaneously also fix issues with its formatting, see PEP 257.

kishcs commented 4 months ago

Looks fine. We can review and close minor PRs.

keikoro commented 4 months ago

@kishcs That's kind of a weird thing to say to an admin as a random user. The no. of mystery reviews on this non-essential PR by unrelated 3rd parties makes this increasingly look like an excercise to me. It's def. reminiscent of Hacktoberfest a few years back, when people put quantity of contributions over quality.

We can review and close minor PRs.

We can also learn from suggestions on how to improve the quality of our contributions, especially when that requires very little effort.

kishcs commented 4 months ago

Definitely. I was just telling to reduce the PR count and to narrow down the focus on real issues and PRs. In case it's no quality, you can reject it too. 🙏

keikoro commented 4 months ago

The chronology of actions taken on this PR and OP not showing interest in improving their submission is fascinating, in any case. Guess I wasn't too far off with what I said last.