Fix ffmpeg_reader not selecting a default stream

Zulko / moviepy

Video editing with Python

https://zulko.github.io/moviepy/

MIT License

12.07k stars 1.51k forks source link

Fix ffmpeg_reader not selecting a default stream #2114

Open bzczb opened 4 months ago

bzczb commented 4 months ago

fix #869 #899 ffmpeg, at least the version that's installed automatically with moviepy, sometimes comes up with no default stream for a given input file. This PR does nothing more than set a default stream automatically when none is specified, which is the cause of the missing "video_fps" issue.

Unfortunately I fixed this bug a long time ago in a working branch, and can't find the file that raised this problem in the first place. I think it was a ".wmv" or ".asf".

coveralls commented 4 months ago

coverage: 81.835% (-0.07%) from 81.904% when pulling 338335b988babed6499fa504d15070f0067b4ee2 on bzczb:i869-default-stream into bc8d1a831d2d1f61abfdf1779e8df95d523947a5 on Zulko:master.

keikoro commented 3 months ago

@bzczb Thanks for the submission – I don't have time to review its actual contents, but saw it didn't pass the formatting checks. Could you update the formatting?

bzczb commented 3 months ago

@keikoro formatting fixed. Can't get pre-commit setup in CONTRIBUTING.md to work any which way. 3.6 venv fails when doing pip install -e, 3.12 venv fails because it's not 3.6.