search

Zulko / moviepy

Video editing with Python
https://zulko.github.io/moviepy/
MIT License
12.07k stars 1.51k forks source link

In Contributing, correct Gitter & mention subreddit #2136

Closed sohang3112 closed 1 month ago

sohang3112 commented 3 months ago

Fixes Issue 2131

sohang3112 commented 3 months ago

@keikoro Please review & merge this PR - Gitter link in CONTRIBUTING.md is corrected, there are no code changes.

sohang3112 commented 2 months ago

@keikoro Please merge this PR

keikoro commented 2 months ago

@sohang3112 Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation because that will just set unrealistic expectations.

I'm not even sure the Gitter should still be on there as none of us check in there regularly AFAIA.

keikoro commented 2 months ago

@sohang3112 But ok, the Gitter link needs at least correcting. Please update the PR so it only includes the link fix and I'll merge it.

sohang3112 commented 2 months ago

Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation

The Reddit link is already there in the README. If it shouldn't be mentioned, then it should be removed from README also.

sohang3112 commented 2 months ago

@keikoro Should I remove Reddit link from both README.md and CONTRIBUTING.md in my PR?

sohang3112 commented 2 months ago

@keikoro Removed Reddit link from both README and CONTRIBUTING. Please check & merge this PR.

sohang3112 commented 1 month ago

@keikoro Please merge this PR

keikoro commented 1 month ago

@sohang3112 as said before:

Please update the PR so it only includes the link fix and I'll merge it.

sohang3112 commented 1 month ago

@keikoro I have added back the Reddit link in README, so now the only diff is the Gitter link corrected in CONTRIBUTING. Please merge it now.

coveralls commented 1 month ago

Coverage Status

coverage: 81.904%. remained the same when pulling 4460bb20c275bb5b972100c9f720761fff641ab9 on sohang3112:patch-1 into bc8d1a831d2d1f61abfdf1779e8df95d523947a5 on Zulko:master.

coveralls commented 1 month ago

Coverage Status

coverage: 81.904%. remained the same when pulling 4460bb20c275bb5b972100c9f720761fff641ab9 on sohang3112:patch-1 into bc8d1a831d2d1f61abfdf1779e8df95d523947a5 on Zulko:master.

keikoro commented 1 month ago

Merged. Thanks for the fix.

Next time, please rebase/squash corrections of corrections of corrections on your end – a tiny change like this oughtn't pollute the commit history with multiple redundant commits. Thx.