search

Zunenonooo / dompdf

Automatically exported from code.google.com/p/dompdf
0 stars 0 forks source link

border-collapse doesn't retain borders on page break #512

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
If you are using a table with border-collapse and the table breaks between 
pages, the first row on the new page is missing it's top border.

An example:
http://gyazo.com/35f1a842452090c8f3c6035e74438211.png?1341340765

Original issue reported on code.google.com by makethat...@gmail.com on 3 Jul 2012 at 6:51

GoogleCodeExporter commented 8 years ago 
Which version of dompdf? Can you post some sample HTML? I'm unable to reproduce 
the problem with a simple document.

Also, your example shows the last row on the first page is missing its bottom 
border. The first row on the new page appears fine.

Original comment by eclecticgeek on 5 Jul 2012 at 8:48

GoogleCodeExporter commented 8 years ago 
Sorry for not providing all this before.

This is the code you can use to reproduce the problem.

table {
    border-collapse: collapse;
    border: 1px solid #000;
}
table th, table td {
    border: 1px solid #000;
}

Sorry, I phrased it wrong I meant the last row of the first page is missing 
it's bottom.

Also I am using DOMPDF 0.6.0 beta 3

Original comment by makethat...@gmail.com on 5 Jul 2012 at 9:02

GoogleCodeExporter commented 8 years ago 
I have the same issue :(
Any idea ?

Original comment by jtrau...@opencomp.fr on 8 Aug 2012 at 9:04

Attachments:

GoogleCodeExporter commented 8 years ago 
A similar issue was discussed here: http://stackoverflow.com/a/11689797/264628

I have, so far, been unable to reproduce the problem. Can either of you attach 
or post online a sample document that exhibits the issue?

Original comment by eclecticgeek on 9 Aug 2012 at 3:56

GoogleCodeExporter commented 8 years ago 
Hi ! Thanks for your reply.
I attach a sample pdf that exhibits the issue.

By the way, I also do not understand why dompdf include a large whitespace 
under "Orthographe grammaticale"  while the other titles with niveau3 class 
have my 5px bottom padding only :/

Am I doing something wrong ?

Original comment by jtrau...@opencomp.fr on 9 Aug 2012 at 9:43

Attachments:

GoogleCodeExporter commented 8 years ago 
Do you use the 0.6 beta 3 version? Could you try with the latest revision from 
the SVN trunk too?

Original comment by fabien.menager on 11 Aug 2012 at 12:54

GoogleCodeExporter commented 8 years ago 
Hi Fabien :) Thanks for your reply.

Yes, I use 0.6 beta 3 version. I have just downloaded the latest revision from 
the SVN trunk but the problem persists.
When in doubt, I removed Google Web Font and substituted with Helvetica but it 
doesn't change anything.

Original comment by jtrau...@opencomp.fr on 11 Aug 2012 at 3:29

Attachments:

GoogleCodeExporter commented 8 years ago 
I am still unable to reproduce this. Perhaps it has something to do with your 
system libraries. Can you post the information provided by dompdf/www/setup.php?

Also, I would be interested in seeing what dompdf is working with. Can you post 
what's returned by $dompdf->output_html() and an uncompressed PDF using 
$dompdf->stream(array('compress'=>0))? Don't open in your PDF viewer and then 
save because a lot of viewers will modify the PDF on save. So be sure to save 
directly from the web browser or use $dopmdf->output(array('compress'=>0)).

Original comment by eclecticgeek on 13 Aug 2012 at 6:36

GoogleCodeExporter commented 8 years ago 
I have attached a screenshot of settings, the html output and an uncompressed 
PDF

Original comment by jtrau...@opencomp.fr on 14 Aug 2012 at 11:22

Attachments:

GoogleCodeExporter commented 8 years ago 
Ok, just wanted to make sure the line wasn't rendered but hidden, but that does 
not appear to be the case. It could be, though I can't imagine why, that the 
top border is being rendered but not the bottom one. What happens if you use 
border-collapse: separate?

The only other thing I can think to test against right now would be the PHP 
version. I'm still on v5.3.x, but I've been meaning to add a version selector 
to the debug tool I use. Yet another reason to look into that feature.

Original comment by eclecticgeek on 15 Aug 2012 at 4:52

GoogleCodeExporter commented 8 years ago 
just in case you need more data, I have the same problem.  I've attached the 
html, the pdf, the css and my phpinfo output.

Original comment by erns...@gmail.com on 22 Aug 2012 at 5:24

Attachments:

GoogleCodeExporter commented 8 years ago 
@eclecticgeek > I have already tested with border-collapse: separate;
It works but just looks ugly :p

Original comment by jtrau...@opencomp.fr on 22 Aug 2012 at 5:26

GoogleCodeExporter commented 8 years ago 
It seems to be a problem with PHP 5.4. I'll into the changelog of PHP 5.4.

Original comment by fabien.menager on 22 Aug 2012 at 6:47

GoogleCodeExporter commented 8 years ago 
I am also facing this issue of a missing bottom table border on page break in 
dompdf.

@eclecticgeek - You mention you are unable to recreate this problem. Does this 
mean you obtain a bottom border on table rows that spill onto the multiple 
pages? One thing I noticed is that when I use a repeating table header <thead> 
this problem emerges.

@fabien.menager - Looking into the PHP 5.4 issue, have you found something?

I appreciate any response. Thanks!

Original comment by parfait....@gmail.com on 20 Sep 2012 at 9:08

GoogleCodeExporter commented 8 years ago 
I do see the bottom border as expected. The test cases provided so far haven't 
used a repeating header, so I haven't tested with that setup. A quick test and 
that doesn't appear to matter.

If the problem is due to a change in PHP 5.4 I won't be able to test for that 
until I add a PHP version selector to my debugger since my site is currently on 
PHP 5.3.

Original comment by eclecticgeek on 21 Sep 2012 at 3:23

GoogleCodeExporter commented 8 years ago 
I have the sampe problem and version of PHP is 5.3.3

Original comment by robyflo...@gmail.com on 11 Oct 2012 at 2:10

GoogleCodeExporter commented 8 years ago 
I ha justve tested with PHP version 5.3.14 but the issue is exactly the same.
Do you need more info ? Have you got an idea to solve the problem ?

Original comment by jtrau...@opencomp.fr on 13 Oct 2012 at 7:37

GoogleCodeExporter commented 8 years ago 
i had the same problem and i fixed it using:

border-spacing: 0px;

instead of border-collapse: collapse; 

good luck!

Original comment by juank...@live.com on 16 Oct 2012 at 9:19

GoogleCodeExporter commented 8 years ago 
it's not a complete fix but it's a work-around

Original comment by juank...@live.com on 16 Oct 2012 at 9:32

GoogleCodeExporter commented 8 years ago 
I had this same issue until I added thead and tbody tags in the appropriate 
places in my table HTML.  That appears to be the fix.  Adding thead and tbody 
also seems to tell dompdf to repeat the thead at the top of every subsequent 
page of the table... which was a happy surprise.

Original comment by dougfel...@dougfelton.com on 18 Oct 2012 at 5:19

GoogleCodeExporter commented 8 years ago 
I can confirm that :)
Really glad ! Solution from comment #20 works like a charm !

Original comment by jtrau...@opencomp.fr on 18 Oct 2012 at 9:15

GoogleCodeExporter commented 8 years ago 
<table border="0" cellpadding="0" cellspacing="0" 
style="border-collapse:collapse; border:1px solid #000;">

Original comment by xan...@gmail.com on 7 May 2013 at 3:18

GoogleCodeExporter commented 8 years ago

Original comment by eclecticgeek on 24 May 2013 at 3:00