search

ZupIT / header-license-checker

Other
1 stars 1 forks source link

Checking of Start Year and Current year and Config.json #15

Open hectorcustodiozup opened 2 years ago

hectorcustodiozup commented 2 years ago

Currently it seems that the license header looks for two year validation Line of code. The Start Year and the Current Year, is this behavior the mandatory? or is there a reason to be so? I am asking because every time it runs the validation sometimes it breaks only because the current year is not found, it requires changes on the Header of older files which have already been validated in later commits.

A second issue would be the name of the configuration file config.json https://github.com/ZupIT/header-license-checker/blob/635176fe2d08208c8256fd96cebae5c9a47e633c/main.js#L22 which maybe is not very intuitive for its purpose and for new users of the projects implementing the action.

thallesfreitaszup commented 2 years ago

hey @hectorcustodiozup after see the issue i think it can not be mandatory as a lot of projects do not use this as pattern.We will talk in the next week about that and return some options so we can discuss with you. Thanks for the contribution

About the configuration file, i agree that is not very intuitive. Do you think that license.json is a better name? or that the user could specify the config file?