search

Zuzu-Typ / PyGLM

Fast OpenGL Mathematics (GLM) for Python
zlib License
207 stars 28 forks source link

manylinux and darwin wheels #56

Closed einarf closed 4 years ago

einarf commented 4 years ago

It would be nice to have manylinux and macosx/darwin wheels on pypi. I guess it doesn't really matter too much for linux, but at least for darwin users it's not really straight forward to compile pyglm.

I'm a big fan of things working out of the box for win/linux/darwin for all my pacakges, so this is might an improvement to look into. Ci systems can do this today as well.

aforren1 commented 4 years ago

Hah, I just started trying this out; see https://github.com/aforren1/PyGLM/tree/ci. It uses cibuildwheel to build wheels across all platforms. All successfully build & pass tests, but haven't worked out uploading them anywhere...

aforren1 commented 4 years ago

Testing wheels here: https://github.com/aforren1/PyGLM/releases/tag/testing

Zuzu-Typ commented 4 years ago

It's looking pretty nice already! Great work 👍

I hope you don't mind me pulling it over to the build-win-linux-mac branch, trying to get it to run on my end as well

einarf commented 4 years ago

Tried a few of the OS X wheel. Worked!

Zuzu-Typ commented 4 years ago

Seems to work like a charm now.

Thanks again @aforren1, I wouldn't have been able to accomplish this without you (:

Now I only need to find a way to upload the files to the PyPI without too much manual work. 😅

aforren1 commented 4 years ago

I think you can also feed in PyPI credentials as part of the process? e.g. https://github.com/joerick/cibuildwheel/blob/master/examples/travis-ci-deploy-only.yml

einarf commented 4 years ago

Absolutely awesome. I can use this library in moderngl examples and moderngl-window now 😄

Zuzu-Typ commented 4 years ago

I think you can also feed in PyPI credentials as part of the process? e.g. https://github.com/joerick/cibuildwheel/blob/master/examples/travis-ci-deploy-only.yml

It might work now. Only the future can tell (:

einarf commented 4 years ago

Got it working in the glcontext project : https://github.com/moderngl/glcontext I'm just adding the PyPI token in the env config on travis-ci (for all branches so tags are included)