search

Zverik / Level0

Web-based OpenStreetMap Editor
http://level0.osmz.ru
Do What The F*ck You Want To Public License
53 stars 14 forks source link

Revert Changes button does not work as expected #28

Open polarbearing opened 8 years ago

polarbearing commented 8 years ago

When adding a changeset to the editor, I see no difference between "Add to editor" and "Revert changes". Let's add c38062689, which created 5 relations and turned a way around. The editor shows the CS as it was submitted to the database, such as turn:lanes:backward and the relations as new objects with negative IDs.

When I submit this, the way remains unchanged, and the relations are added to the database again, so I have twice as much. I removed them later with loading the relation numbers manually and putting the minus in front.

From the button "Revert changes" I would expect some reverting support, such at least finding the object IDs of the relations added, and maybe loading the state of the way before the CS in question, and maybe adding minus signs for created objects in order to delete them.

If that is not possible, disabling the "Revert changes" button would avoid confusion.

Zverik commented 8 years ago

Well, reverting changes in this case mean undoing edits that were done in the editing session. I see this is unclear :) I'll think of renaming the button to e.g. "Undo changes".

polarbearing commented 8 years ago

But what is currently the difference in the system's response between the buttons "Add to editor" and "Revert changes"? Both load the original changeset.

Zverik commented 8 years ago

It is all explained in the documentation: "Add to editor" downloads data from the URL field and appends it to the data currently being edited (as opposed to "Replace data"). "Revert changes" downloads latest versions of all objects in the editor and replaces edited data with these.

There are no buttons to alter or process data in any way. As there is no web sites for reverting changesets (yet). You have only two options for that: either with JOSM reverter plugin, or with the simple-revert command-line script.

polarbearing commented 8 years ago

"Undo changes" is good then and avoids confusion with the OSM reverting process, "Reload data in editor" would be clear as well.

It would be good to have a button that, when I give a changeset URL, loads all objects touched in this changeset (in their current state, with the real object IDs), instead of loading the changeset itself (with the negative object IDs). Label e.g. "Load changeset objects".