Zverik / Level0

Web-based OpenStreetMap Editor
http://level0.osmz.ru
Do What The F*ck You Want To Public License
54 stars 14 forks source link

Fixing empty values causes "Nothing to upload" #32

Open polarbearing opened 7 years ago

polarbearing commented 7 years ago

When I fix an object that has a trailing space, or a key with an empty value, the space or the key with the empty value is already removed automatically while the data are added to the editor.

If nothing else is changed in the data, Level0 complains "Nothing to upload" and does not create a changeset.

Zverik commented 7 years ago

Are you sure? Please try this taginfo page, click on the "Level0" link in the top right corner and then "Show osmChange" to verify the osc file.

Can you provide me with an example object on which level0 refuses to upload changes?

polarbearing commented 6 years ago

Not sure anymore. I remember my problem was with a space in the value, not in the key as in your example (for which there are zero occurences now). Anyway, I tested now and successfully fixed a

Could not find a leading space in a key; or a key with an empty value, currently.

I found a CS removing an empty value 30s after this ticket was created. Maybe it worked in the end. We should probably close as not reproducible for now. don't remember what trick I used.

polarbearing commented 6 years ago

Found plenty keys with empty values now, overpass query [~"."~"^$"] https://www.openstreetmap.org/way/32958037 has <tag k="source:width" v=""/>

Loading into level0 automatically strips this key. "Upload to OSM" produces red "Nothing to upload."

Show osmChange displays:

OsmChange contents (this will be uploaded to the server)
<?xml version="1.0" encoding="UTF-8"?>
<osmChange version="0.6" generator="Level0 v1.2">
</osmChange>

Trying on a node as well (n5176220022), same result.