Zverik / Nik4

Mapnik to image export
Do What The F*ck You Want To Public License
123 stars 23 forks source link

add capabilities to register new font's directories #16

Closed lucadelu closed 9 years ago

lucadelu commented 9 years ago

In these two commits I added the capabilities to register new font's directories and cleanup the code replacing tabs with space.

Zverik commented 9 years ago

Hi, thanks for the PR. Do you mind if I merge only the font directories commit? This project's style is with tabs, I like them (and it's easier to do occasional edit on a vim-less PC).

lucadelu commented 9 years ago

No, I don't mind but you should use spaces as required from Python (by PEP8) and specially if someone is using a Python IDE (as Spyder) it start to mix spaces and tabs and this is really a mess. Obviously you are free to use tabs ;-)

Zverik commented 9 years ago

PEP is not a requirement (if not contributing to python itself), but merely a recommendation. Modern IDEs are able to see what kind of indentation is needed.

lucadelu commented 9 years ago

Ok, so merge only the font directories commit.

Zverik commented 9 years ago

Closed with d557d4be5c32e08f8788c6fe4b7a664344633f19 (sorry, had to copy-paste edits instead of merging).