search

Zverik / Nik4

Mapnik to image export
Do What The F*ck You Want To Public License
123 stars 23 forks source link

allow different tile counts in x/y direction #35

Closed woodpeck closed 5 years ago

woodpeck commented 5 years ago

Adds new cmdline flags --tiles-x and --tiles-y for situations where you want to tile differently in x/y direction, e.g. a 50000x10000 image would only need 4x1 tiles but currently you are forced to have 4x4 tiles. Sadly I lack the python foo to make it use a buffer around tiles - currently the boundary between tiles suffers from cut-off labels and this is my patch to at least reduce the number of tile boundaries to a minimum.

Zverik commented 5 years ago

Hi Frederik, thanks for the pull request. I agree this feature is useful. But I think the UI could be improved a bit. What do you think of keeping the old --tiles argument, but allowing it to accept NxM values — e.g. --tiles 4x1? This won't break old workflows (with --tiles 4), but would solve issues like the one you had.

woodpeck commented 5 years ago

Good idea. Does this new version work? I was unsure if it acceptable to patch around in the options hash and (ab)use that to transport the synthetic x/y variables but it seemed easiest.

Zverik commented 5 years ago

Yes, you did great. There are some minor issues in the comments, above. I'll test it in the evening, when I get to my home laptop.