search

Zverik / every_door

A dedicated app for collecting thousands of POI for OpenStreetMap
https://every-door.app
ISC License
424 stars 36 forks source link

Rework MultiCombo fields UI to accept a choice of values #496

Open jolesh opened 2 years ago

jolesh commented 2 years ago

Diet tagging has three possible values: yes, no, only

Maybe make a small table with the diet forms on the left and the values selectable, like this: Diets: | vegetarian | no | yes | only | | vegan | no | yes | only | | halal | no | yes | only | ...

Maybe accessible through a menu, just like opening hours opens a dialog.

Robot8A commented 1 year ago

I support this. Checking the code, it should require either adding a new ComboType, or changing the current ComboType.multi behaviour.

Zverik commented 1 year ago

Hmm. It looks like I did the multiCombo fields wrong, not even supporting "no" values. The iD editor does it right though.

One question: can multiple diet options have the only value?

Robot8A commented 1 year ago

Yes, one restaurant could be both for example only gluten-free and only vegetarian.

patepelo commented 1 year ago

It would be similar to "Take away only" field.

Maybe we can take the code from there and reuse it?