Zverik / every_door

A dedicated app for collecting thousands of POI for OpenStreetMap
https://every-door.app
ISC License
420 stars 36 forks source link

Unintended POI confirmations #601

Open AntonKhorev opened 1 year ago

AntonKhorev commented 1 year ago

Currently it's easy to confirm a POI without an intent to do so and not notice it. This is likely due to a number of UI decisions in Every Door:

Example:

https://www.openstreetmap.org/node/4689641387/history

I see that a shop was was closed and another one opened at the same place. In the data I see version 3 which is obsolete. But it was confirmed two days ago. It's very unlikely for a shop to close and reopen that fast. Who confirmed it? Turns out it was me. But I didn't do that. Is it a bug? Then I realize I walked along a different street nearby two days ago and probably accidentally confirmed the shop.

AntonKhorev commented 1 year ago

I think there's also a delay between map scroll and list update, maybe if a lot of data is loaded. Tapping the list then may result in something else confirmed.

One possible fix for all this is displaying the last edited poi on the main screen. Now you have to go to Configuration > Pending uploads and I'm not sure how those are ordered. Are notes listed there before elements?

Zverik commented 1 year ago

Many good points, some of which I encountered myself. I have no idea how to tackle them at the moment, but I'll see what I can do.

Regarding the last question, pending uploads are always sorted by time edited — but notes first, then OSM elements. So yeah, there are timestamps in the app database.

deevroman commented 1 year ago

you can try adding animation/vibration when confirming the poi. But we need to test whether it will be distracting.

Confirmation status is not visible on the map.

In the filter menu, you can hide confirmed POIs. So far, this is the only way to influence.

AntonKhorev commented 1 year ago

In the filter menu, you can hide confirmed POIs. So far, this is the only way to influence.

Usually I want to see confirmed pois too. If a confirmed poi changes I'd want to edit it. Otherwise it will be like StreetComplete where you are not allowed to edit unless a quest is generated.

AntonKhorev commented 1 year ago

I noticed how I made one of unintended confirmations.

There were two pois close to each other, let's call them A and B. A was closer to the map view center and was first in the list. I wanted to confirm A, but I also remembered that B was nearby. Then I'm not exactly sure what happened, but I probably moved the map closer to B. But I probably didn't see B immediately because I decided to confirm A first. So I tapped the place on the screen where A was initially.

After that I made sure that B exists, probably moved the map again, and was going to confirm it when I noticed that it was already confirmed. Apparently the poi list got reordered and B got to the first position. When I was tapping the place where I thought was A, it was already occupied by B. Or maybe the list updated with a delay, and there was A at the moment, but the tap was registered on B.