Banks not showing up in the suggestions from NSI

Zverik / every_door

A dedicated app for collecting thousands of POI for OpenStreetMap

https://every-door.app

ISC License

417 stars 35 forks source link

Banks not showing up in the suggestions from NSI #687

Open andreadecorte opened 10 months ago

andreadecorte commented 10 months ago

How to reproduce:

Add a new POI, location is France
Search for type "Credit"
I get a man_made=surveillance named Crédit Agricole (not clear from where it comes from?) but no banks starting with this name (https://github.com/osmlab/name-suggestion-index/blob/main/data/brands/amenity/bank.json#L5087-L5098 at least Crédit Agricole should be there, but there are others there which should match, for example https://github.com/osmlab/name-suggestion-index/blob/main/data/brands/amenity/bank.json#L5166).

Location is FR so it should match the restriction.

andreadecorte commented 10 months ago

Ah I understand now, it was because I was in the generic Poi mode, not in the shop mode, and we get the warning about being in the wrong mode only after choosing the specific type. And the surveillance preset comes from NSI

Should the search from NSI return also types from other views, maybe with a warning icon or greyed out? This would help the user IMO, as you already show amenity=bank there despite being in the wrong view, so behaviour is not totally consistent