search

Zverik / every_door

A dedicated app for collecting thousands of POI for OpenStreetMap
https://every-door.app
ISC License
410 stars 35 forks source link

[Request] Add support for Waterway Dam #755

Closed Coehill closed 2 weeks ago

Coehill commented 3 months ago

waterway=dam would be a useful addition for those traveling in canoes, kayaks, boats, etc.

mnalis commented 3 months ago

Can you specify what seems to be the problem? I seem to have the option to add waterway=dam in EveryDoor 5.1 (Android)

Coehill commented 2 months ago

Can you specify what seems to be the problem? I seem to have the option to add waterway=dam in EveryDoor 5.1 (Android)

Sure! When trying to add waterway=dam, there is a yellow warning "this object type is not supported". Additionally, Dam points are not displayed or editable on the map (see comparison of Every Door vs. OsmAnd~ below). Hopefully this helps.

78d9264b-1862-4ad2-9471-0c68767a08c3

70aa1df7-a912-47d3-b5c3-ff93ccd0582e

0319904a-54bd-4f41-a166-69c8981b64b9

Coehill commented 2 months ago

Relevant code: https://github.com/Zverik/every_door/blob/ed9bf4c47548920ac668be57484dc91ece6612a3/lib/helpers/poi_warnings.dart#L63

https://github.com/Zverik/every_door/blob/ed9bf4c47548920ac668be57484dc91ece6612a3/lib/helpers/good_tags.dart#L267

I think it just needs dam to be added in an if statement in good_tags.

mnalis commented 2 months ago

But waterway=dam node should snap on waterway ways, though, right? I'm not sure if just adding to good_tags is going to do that...

Zverik commented 2 weeks ago

This is actually sensible. 5.2 will support waterway features, and will snap most of them to nearby waterways.