Zxynine / EvenBetterComments

My take on the better-comments extension which incorporates many pull requests and multi tag definitions
https://marketplace.visualstudio.com/items?itemName=Tion.evenbettercomments
MIT License
11 stars 1 forks source link

[bug] tags match outside comments in markdown files #4

Closed Fred-Vatin closed 1 year ago

Fred-Vatin commented 1 year ago

image

Zxynine commented 1 year ago

That’s very odd, can you do me a favour, I am out of the house today, hop into the file, press control shift p to open up the command pallets and find the “show line tokens” command from even better comments. Have the line with the unexpected highlights selected and it should output all of the tokens for that line into the console. I have a feeling that markdown files don’t have a proper single line comment delimeter so everything appears as a comment or something

Fred-Vatin commented 1 year ago

Here it is when it’s a markdown comment image

Text: '<!--'
Line: 5
Length: 4
Scopes:
  - comment.block.html
  - punctuation.definition.comment.html
  - text.html.markdown
Base Scope: comment

---
Text: ' todo '
Line: 5
Length: 6
Scopes:
  - comment.block.html
  - text.html.markdown
Base Scope: comment

---
Text: '-->'
Line: 5
Length: 3
Scopes:
  - comment.block.html
  - punctuation.definition.comment.html
  - text.html.markdown
Base Scope: comment

Here it is when it matches outside of comment in markdown image

Text: 'todo'
Line: 7
Length: 4
Scopes:
  - meta.paragraph.markdown
  - text.html.markdown
Base Scope: meta
Zxynine commented 1 year ago

I fixed it, should be a hot fix out tonight. Thanks for the help.

Fred-Vatin commented 1 year ago

I confirm it is fixed 👍