Zylann / godot_heightmap_plugin

HeightMap terrain for Godot implemented in GDScript
Other
1.74k stars 159 forks source link

LowPoly shader doesn't seem to work #275

Open Maveyyl opened 3 years ago

Maveyyl commented 3 years ago

Version 1.5.2 downloaded on the asset lib, on Godot_v3.3.2-stable_mono_win64

The terrain takes the texture of the first texture by default in other shaders, but when I change to shader type LowPoly it stops coloring the terrain with the first texture. I can still modify the height of the terrain, and paint color, but I cannot paint a texture on it.

If I try to paint a texture I get this error:

SCRIPT ERROR: paint_input: Assertion failed. At: res://addons/zylann.hterrain/tools/brush/terrain_painter.gd:286

Zylann commented 3 years ago

The shader works, it really just doesn't do textures. If you want textures you have to modify it. It's not "just available" because there are many shaders to maintain already and adding options for everything everywhere is an endless task (one could also want to not have textures), which is always best covered by custom tweaking.

The error is a consequence of the fact the chosen shader does not use splatmaps. If the shader is modified to use one, it will stop printing them. Perhaps painting textures should just do nothing in this case instead of falling back on an assert.

Maveyyl commented 3 years ago

Oh ok so I should use coloring instead? Got it. Thanks :)