Zylann / godot_heightmap_plugin

HeightMap terrain for Godot implemented in GDScript
Other
1.74k stars 159 forks source link

Import textures dialog is so large it does not fit on screen and is unusable #423

Open Pshy0 opened 9 months ago

Pshy0 commented 9 months ago

Describe the bug The import texture dialog is so large I cannot access some options and buttons at the bottom. The dialog cannot be resized because it is so large that the upper and lower bounds are unreachable.

To Reproduce Undetermined

Expected behavior This window should fit the screen, or, at least, the bottom and/or lower bound of the window should be reachable for resizing it.

Screenshots This is a screenshot from the very top of my screen to the very bottom: image

Environment

Zylann commented 9 months ago

Wow, that's really weird, it's not supposed to be that tall. I've never seen it do that.

Also, I wonder why it's not an actual window Oo because the Godot editor should use native windows, not embedded ones. When I open this window, it shows up very tall, but at least it is a native window, so I can use it by clicking its border and resizing it. So unfortunately, it's going to be hard for me to understand why it's not using a native window on your computer.

I checked the scene res://addons/zylann.hterrain/tools/texture_editor/set_editor/texture_set_import_editor.tscn, and indeed for some reason the window was super tall. I haven't done that. I suppose Godot had a bug of some sort of behavior change when going up versions, and messed it up at some point...

image

I tried setting the height back to 623 like it was originally, saved it, but when I reopen it, Godot stretches it back super tall...

Zylann commented 9 months ago

After some fiddling about, I found a label had "autowrap" enabled: now in Godot 4.2 you must set a minimum size on it otherwise it messes things up. No idea why that wasn't a problem in the past. Changing that seems to fix the tall size. This shows a small warning icon in the scene tree, but isn't mentionned anywhere in the docs apparently.

Related to https://github.com/godotengine/godot/issues/83546

I pushed the fix in the plugin in 1b9c76b89c8269f581e1cedb4a2a414823531a55

Calinou commented 8 months ago

https://github.com/godotengine/godot/issues/86136 was recently resolved in master, so maybe the workaround won't be needed anymore in 4.3.