Zylann
commented
2 years ago Having a look.
Notes:
- your
instances.trescontains images that went embedded directly inside the file as text. This will blow up the size of the resource (14Mb) and makes it slower to load. Maybe try not creating newImageTexturesfrom the inspector? It also contains mesh data. Or could it be that you tried to "make unique"? I would also advise against that on a mesh. - I could not find any
NoiseTexturein the entire project. I guess it is the images you created? OrFastNoiseLite?
It's hard to tell yet at first what is going on but it seems like Godot is simply very badly handling the fact many rigidbody transforms are set at once in the editor (they are created for collisions). It tries to update configuration warnings of ALL the bodies which in turn is emitting signals which go to message queue and it's a callback-fest of deferred stuff going into the message queue, ultimately leading to... nothing, because these nodes are not editable in the scene tree anyways...
There are many bodies because when you remove the noise, the instancer will no longer attempt to filter density anymore. So it will spawn a lot more instances with collision in every chunk, so you'll end up with hundreds of physics bodies in your scene. While the physics engine might be able to handle this, the editor however is doing really inefficient things under the hood that kill performance.
I tried bumping the size of the message queue to 400Mb instead of the default 4Mb to see where it leads. Now removing the noise takes a second with no issues.
I had a look at Node::update_configuration_warnings and it seems like it keeps emitting signals even if the node cannot be seen in the editor. I tried to change it, and it also fixed the issue:
#ifdef TOOLS_ENABLED
inline bool can_node_be_seen_in_editor(Node &node) {
if (!node.is_inside_tree()) {
return false;
}
const Node *edited_scene_root = node.get_tree()->get_edited_scene_root();
if (edited_scene_root == nullptr) {
return false;
}
if (edited_scene_root == &node) {
return true;
}
// Not sure why `is_ancestor_of` is required
return edited_scene_root->is_ancestor_of(&node) && node.get_owner() == edited_scene_root;
}
#endif
void Node::update_configuration_warnings() {
#ifdef TOOLS_ENABLED
if (can_node_be_seen_in_editor(*this)) {
get_tree()->emit_signal(SceneStringNames::get_singleton()->node_configuration_warning_changed, this);
}
#endifUsing signals like this isn't great though IMO. Because if these bodies happened to be visible instead (which is possible in other games with large scenes, who knows), the problem will also happen as soon as you do a bulk move. A better solution would be to store a version number which the scene tree dock can poll on visible nodes (never more than a few dozens). When it compares different to the last shown, update it. No faffing around with signals. But that sounds like a larger change to make.
rcorre
Godot: 4.0.alpha.custom_build.8243c7ab5 Voxel: 31a7ddbf838572e50415159a56720275f9523262
When I try to remove the noise texture from the voxel instancer in the attached project, Godot consumes 100% CPU for around a minute, then crashes.
It prints messages like:
I sampled a few stacks throughout, they tend to have HashMap/MessageQueue near the top:
example.zip