search

Zytharian / RbxStargate

v20 of Stargates implemented on Roblox
MIT License
7 stars 3 forks source link

Fix glyph lighting when origin is in address #19

Closed PhaserArray closed 1 year ago

PhaserArray commented 1 year ago

This pull request fixes issue #18 by undoing certain changes made in commit 454ea365. See issue for more details.

Zytharian commented 1 year ago

The problem with this approach is it just reverts a (buggy) fix to a related issue. If we have code that looks like the following then during the 5s wait between Dial() and Connect() the DHD will display the origin as selected.

local gate = _G.Stargates:FindStargate("Pegasus Gate") --this API doesn't currently exist, pretend it does.
gate:Dial({1, 2, 3, 4, 5, 6, gate.Origin.Value})
wait(5)
gate:Connect()

I'll probably still merge this since I'd rather have this bug than the one this change fixes and I'm not seeing a better way around it right now (i.e. there's no way to arbitrarily determine whether an input symbol is the end of the dial or not except if we hit max address length).