search

Zytharian / RbxStargate

v20 of Stargates implemented on Roblox
MIT License
7 stars 3 forks source link

Fixed DHD symbol not glowing even though POI is manual, and shuffled the anim:deactivation code to fix pegasus deactivation animation. #2

Closed ayrtondutchman closed 3 years ago

ayrtondutchman commented 3 years ago

Fixed a bug with the DHD where the origin wouldn't light up when manually input. Before it would just always turn off the light with activatorInputsOrigin = false;. Now it will turn on with alwaysLightOrigin=true;. And it will stay turned on (till deactivation) when activatorinputsorigin = false;

Fixed deactivation animation for pegasus gate. Before it would deactivate the symbols as soon as the gate shutdown (they were the first in the script to deactivate) Now they will deactivate at the same time with the chevrons.

Zytharian commented 3 years ago

Hi, thanks for the pull request. I have a few code review comments.

  1. In onStateChanged, line 433 (if (not originPartOfAddr) then) is where you'd want to change the if statement. Where the change is currently can prevent the activator from lighting up.
  2. I'm not opposed to the new config option, but where would it be used? I imagine it'd be odd to most players that a button they didn't click lights up.
  3. The pegasus anim follows SGA Rising Pt 1 when they first come through the gate to Atlantis. The symbols deactivate first in that scene. Is there a reason this should be changed? Are there scenes with the symbols deactivating along with the chevrons?
  4. Could you remove the version and last updated change on the script? It's fine to keep the username for credits. I would prefer to update the version/date myself prior to pushing changes to the Roblox website.
ayrtondutchman commented 3 years ago

Hello @Zytharian! Thanks for reacting and the review comments. Sorry for the late reaction have been busy with school lately

  1. I am surprised I oversaw this. Will fix this.
  2. This was more to test it out if it worked and I kinda liked how it looked. I don't think it's really needed indeed so will remove that.
  3. I am surprised I never noticed that. I had to get the dvds for the serie to check it out. (can't find any atlantis gate outgoing deactivation online except for the garry's mod stargate addon)
  4. Yes I will! Wasn't really sure what to do with this but I will clear/clean it.

edit: About 3: just saw episode 14 of season 1 (Sanctuary) in this one an outgoing gate closes but the chevrons turn off first, only proves the inconsistency in the series though.

Zytharian commented 3 years ago

Any updates on this? If you don't have time I can make this fix along with a few others.

ayrtondutchman commented 3 years ago

Yea sorry about that. Exams are gonna be starting soon for me so I focused on school and almost forgot about this. Because I have almost no time at the moment I reverted a bit, like the dialAnim and like I said I would remove the extra option.

Do you by any chance have (a) discord? Contact would probably go way easier that way.

I still think that the stargate animation should be looked at. Since Atlantis gate is known to be different from the other gates in terms of cosmetic looks. So might also be in shutdown animation. But there are a few episodes where the lights did go out before the wormhole had fully collapsed but thats something for later.

I believe everything should be good now. Would love to contribute more but that will have to wait till after the exams since I do have a few ideas/suggestions but can't work them out currently.

Edit: You can reach me on discord at hello234561#9000 or my server https://discord.gg/jGRMrNen (forgot that it auto generates 7 day links)

Zytharian commented 3 years ago

Looks good. Will release the update once I fix a related DHD bug with the dial hints.