search

a-b-street / abstr

Generate scenario files for A/B Street with the statistical programming language R
https://a-b-street.github.io/abstr/
Other
34 stars 5 forks source link

Reduce dependencies #6

Closed Robinlovelace closed 3 years ago

Robinlovelace commented 3 years ago

Currently the package has many dependencies. There are advantages of depending on fewer things so will aim to follow the 'tinyverse' principles: http://www.tinyverse.org/

First package on the hit list: dplyr which is big, has many sub-dependencies and takes a long time to install.

natesheehan commented 3 years ago

Had a look, correct me if I am wrong, but abstr is currently using 2 two different dplyr functions:

Is the aim to rewrite these as base-r functions? Also thanks for the tinyverse link, I found this read super interesting https://recology.info/2018/10/limiting-dependencies/

Robinlovelace commented 3 years ago

Is the aim to rewrite these as base-r functions?

Correct. A fun and potentially rewarding refactoring mission!

natesheehan commented 3 years ago

Sounds like a plan! I should have some time to look at this at the end of the week/early next week 🚀

natesheehan commented 3 years ago

base r methods replacing dplyr-> https://github.com/a-b-street/abstr/pull/14

Robinlovelace commented 3 years ago

Job done :tada: